Add histograms definitions for windows enterprise checks.

Add histograms definitions for windows enterprise checks.

BUG=none
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242179

[pastarmovj, 2013-12-18 09:43:24]

Hey, please take a look at this CL. 
Thanks! 
-Julian

[jar (doing other things), 2013-12-18 19:13:34]

It is nicer if you can land this in conjunction with the CL that records the
data.  Is that recording in Chrome?

Also switched to having asvitkine review.

https://codereview.chromium.org/99783011/diff/1/tools/metrics/histograms/hist...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/99783011/diff/1/tools/metrics/histograms/hist...
tools/metrics/histograms/histograms.xml:3593: +  <summary>Whether we were able
to contact the AD Domain Controller.</summary>
Prose like this are often confusing, as it is hard to tell what true vs false
mean.  Better is to define your own enum, and use it.

[pastarmovj, 2013-12-18 21:29:50]

The corresponding code is already in the browser. I am sorry I have missed the
news that the histograms are now part of the main repository and only noticed
after I edited the file today.

See policy_loader_win.cc for the corresponding use of those metrics.

[pastarmovj, 2013-12-19 10:50:48]

https://codereview.chromium.org/99783011/diff/1/tools/metrics/histograms/hist...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/99783011/diff/1/tools/metrics/histograms/hist...
tools/metrics/histograms/histograms.xml:3593: +  <summary>Whether we were able
to contact the AD Domain Controller.</summary>
On 2013/12/18 19:13:34, jar wrote:
> Prose like this are often confusing, as it is hard to tell what true vs false
> mean.  Better is to define your own enum, and use it.

In this particular case I think the true/false or whatever words would come for
this are going to be obvious enough to know which is the value for success and
which not. As well as for the one below. 

I can see your concern with negative propositions like "Disabled bookmarks".

[Alexei Svitkine (slow), 2013-12-19 19:03:28]

https://codereview.chromium.org/99783011/diff/1/tools/metrics/histograms/hist...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/99783011/diff/1/tools/metrics/histograms/hist...
tools/metrics/histograms/histograms.xml:3592: +<histogram
name="EnterpriseCheck.DomainBindSucceeded" enum="BooleanEnabled">
It sounds like BooleanSuccess is the better enum to use here.

https://codereview.chromium.org/99783011/diff/1/tools/metrics/histograms/hist...
tools/metrics/histograms/histograms.xml:3598: +    Enum of possible things that
can fail while checking for enterprise env.
Can you mention when this is logged (i.e. when is enterprise env checked - on
startup? when something happens?).

https://codereview.chromium.org/99783011/diff/1/tools/metrics/histograms/hist...
tools/metrics/histograms/histograms.xml:3603: +  <summary>Whether the machine is
part of an AD domain.</summary>
Mention when this is logged.

https://codereview.chromium.org/99783011/diff/1/tools/metrics/histograms/hist...
tools/metrics/histograms/histograms.xml:3607: +  <summary>The rough Windows
suite we are runnnig on.</summary>
Mention when this is logged.

[pastarmovj, 2013-12-20 10:55:10]

PTAL.

https://codereview.chromium.org/99783011/diff/1/tools/metrics/histograms/hist...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/99783011/diff/1/tools/metrics/histograms/hist...
tools/metrics/histograms/histograms.xml:3592: +<histogram
name="EnterpriseCheck.DomainBindSucceeded" enum="BooleanEnabled">
On 2013/12/19 19:03:29, Alexei Svitkine wrote:
> It sounds like BooleanSuccess is the better enum to use here.

Done.

https://codereview.chromium.org/99783011/diff/1/tools/metrics/histograms/hist...
tools/metrics/histograms/histograms.xml:3598: +    Enum of possible things that
can fail while checking for enterprise env.
On 2013/12/19 19:03:29, Alexei Svitkine wrote:
> Can you mention when this is logged (i.e. when is enterprise env checked - on
> startup? when something happens?).

Done.

https://codereview.chromium.org/99783011/diff/1/tools/metrics/histograms/hist...
tools/metrics/histograms/histograms.xml:3603: +  <summary>Whether the machine is
part of an AD domain.</summary>
On 2013/12/19 19:03:29, Alexei Svitkine wrote:
> Mention when this is logged.

Done.

https://codereview.chromium.org/99783011/diff/1/tools/metrics/histograms/hist...
tools/metrics/histograms/histograms.xml:3607: +  <summary>The rough Windows
suite we are runnnig on.</summary>
On 2013/12/19 19:03:29, Alexei Svitkine wrote:
> Mention when this is logged.

Done.

[Alexei Svitkine (slow), 2013-12-20 14:55:42]

lgtm % nit

https://codereview.chromium.org/99783011/diff/20001/tools/metrics/histograms/...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/99783011/diff/20001/tools/metrics/histograms/...
tools/metrics/histograms/histograms.xml:3595: +    permed once at start-up.
Nit: permed -> performed. Fix throughout.

[commit-bot: I haz the power, 2013-12-20 14:59:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/99783011/50001

[commit-bot: I haz the power, 2013-12-20 17:38:59]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-12-20 18:11:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/99783011/50001

[commit-bot: I haz the power, 2013-12-20 21:29:03]

Change committed as 242179