tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 445d0493c2316c70a978db7fc7df24fa9ee01e44..bf70afd25c57d39abfefa531d2d74bf262098296 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -3589,6 +3589,24 @@ other types of suffix sets.
   <summary>Network error during OAuth2 access token fetch.</summary>
 </histogram>
 
+<histogram name="EnterpriseCheck.DomainBindSucceeded" enum="BooleanEnabled">

[Alexei Svitkine (slow), 2013/12/19 19:03:29]

It sounds like BooleanSuccess is the better enum to use here.

[pastarmovj, 2013/12/20 10:55:10]

Done.

+  <summary>Whether we were able to contact the AD Domain Controller.</summary>

[jar (doing other things), 2013/12/18 19:13:34]

Prose like this are often confusing, as it is hard to tell what true vs false
mean.  Better is to define your own enum, and use it.

[pastarmovj, 2013/12/19 10:50:48]

In this particular case I think the true/false or whatever words would come for
this are going to be obvious enough to know which is the value for success and
which not. As well as for the one below. 

I can see your concern with negative propositions like "Disabled bookmarks".

+</histogram>
+
+<histogram name="EnterpriseCheck.DomainCheckFailed" enum="EnterpriseCheckError">
+  <summary>
+    Enum of possible things that can fail while checking for enterprise env.

[Alexei Svitkine (slow), 2013/12/19 19:03:29]

Can you mention when this is logged (i.e. when is enterprise env checked - on
startup? when something happens?).

[pastarmovj, 2013/12/20 10:55:10]

Done.

+  </summary>
+</histogram>
+
+<histogram name="EnterpriseCheck.InDomain" enum="BooleanEnabled">
+  <summary>Whether the machine is part of an AD domain.</summary>

[Alexei Svitkine (slow), 2013/12/19 19:03:29]

Mention when this is logged.

[pastarmovj, 2013/12/20 10:55:10]

Done.

+</histogram>
+
+<histogram name="EnterpriseCheck.OSType" enum="OsSuite">
+  <summary>The rough Windows suite we are runnnig on.</summary>

[Alexei Svitkine (slow), 2013/12/19 19:03:29]

Mention when this is logged.

[pastarmovj, 2013/12/20 10:55:10]

Done.

+</histogram>
+
 <histogram name="Event.CoalescedCount.Mouse">
   <summary>Number of Mouse events coalesced.</summary>
 </histogram>
@@ -22995,6 +23013,11 @@ other types of suffix sets.
   <int value="4" label="TTLS"/>
 </enum>
 
+<enum name="EnterpriseCheckError" type="int">
+  <int value="0" label="Cound not get net join info."/>
+  <int value="1" label="Cound not bind to domain controller."/>
+</enum>
+
 <enum name="EnterpriseDeviceManagementStatus" type="int">
   <summary>
     Status codes produced by DeviceManagementService for requests made to the
@@ -27845,6 +27868,12 @@ other types of suffix sets.
   <int value="34" label="ERANGE">Numerical result out of range</int>
 </enum>
 
+<enum name="OsSuite" type="int">
+  <int value="0" label="Windows Home Edition"/>
+  <int value="1" label="Windows Proffesional Edition (or better)"/>
+  <int value="2" label="Windows Server Edition"/>
+</enum>
+
 <enum name="OSXExceptionHandlerEvents" type="int">
   <int value="0" label="EXCEPTION_ACCESSIBILITY">
     Object does not support accessibility attributes