Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 997583004: Remove obsolete TakeHeapSnapshot method from API (Closed)

Created:
5 years, 9 months ago by yurys
Modified:
5 years, 6 months ago
Reviewers:
alph, Yang, loislo
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove obsolete TakeHeapSnapshot method from API BUG=chromium:465651 LOG=Y Committed: https://crrev.com/f92c8a36709efb1514846b3bb672c40e4fb4c672 Cr-Commit-Position: refs/heads/master@{#27208}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -16 lines) Patch
M include/v8-profiler.h View 1 chunk +1 line, -8 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 28 (10 generated)
yurys
5 years, 9 months ago (2015-03-12 06:36:58 UTC) #2
Yang
On 2015/03/12 06:36:58, yurys wrote: lgtm.
5 years, 9 months ago (2015-03-12 08:04:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997583004/1
5 years, 9 months ago (2015-03-13 06:09:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/2385)
5 years, 9 months ago (2015-03-13 06:44:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997583004/1
5 years, 9 months ago (2015-03-13 10:40:02 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/2403)
5 years, 9 months ago (2015-03-13 11:35:29 UTC) #11
Yang
On 2015/03/13 11:35:29, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 9 months ago (2015-03-13 11:41:37 UTC) #12
yurys
On 2015/03/13 11:41:37, Yang wrote: > On 2015/03/13 11:35:29, I haz the power (commit-bot) wrote: ...
5 years, 9 months ago (2015-03-13 13:45:29 UTC) #13
yurys
On 2015/03/13 13:45:29, yurys wrote: > On 2015/03/13 11:41:37, Yang wrote: > > On 2015/03/13 ...
5 years, 9 months ago (2015-03-13 13:50:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997583004/1
5 years, 9 months ago (2015-03-14 15:11:01 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/2444)
5 years, 9 months ago (2015-03-14 16:14:04 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997583004/1
5 years, 9 months ago (2015-03-15 06:44:21 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/2452)
5 years, 9 months ago (2015-03-15 07:32:33 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997583004/1
5 years, 9 months ago (2015-03-16 09:22:44 UTC) #24
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-16 09:49:23 UTC) #25
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f92c8a36709efb1514846b3bb672c40e4fb4c672 Cr-Commit-Position: refs/heads/master@{#27208}
5 years, 9 months ago (2015-03-16 09:49:35 UTC) #26
ulan
On 2015/03/16 09:49:35, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
5 years, 6 months ago (2015-06-15 11:44:15 UTC) #27
yurys
5 years, 6 months ago (2015-06-15 11:53:36 UTC) #28
Message was sent while issue was closed.
On 2015/06/15 11:44:15, ulan wrote:
> On 2015/03/16 09:49:35, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/f92c8a36709efb1514846b3bb672c40e4fb4c672
> > Cr-Commit-Position: refs/heads/master@{#27208}
> 
> When removing deprecated functions in future, please add in the description
what
> should be used instead.

Sure.

Powered by Google App Engine
This is Rietveld 408576698