|
|
DescriptionRemove obsolete TakeHeapSnapshot method from API
BUG=chromium:465651
LOG=Y
Committed: https://crrev.com/f92c8a36709efb1514846b3bb672c40e4fb4c672
Cr-Commit-Position: refs/heads/master@{#27208}
Patch Set 1 #
Messages
Total messages: 28 (10 generated)
yurys@chromium.org changed reviewers: + alph@chromium.org, loislo@chromium.org, yangguo@chromium.org
On 2015/03/12 06:36:58, yurys wrote: lgtm.
The CQ bit was checked by yurys@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997583004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...)
The CQ bit was checked by yurys@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997583004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...)
On 2015/03/13 11:35:29, I haz the power (commit-bot) wrote: > Try jobs failed on following builders: > v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, > http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...) I think you either have to fix the call site in Blink or wait for the bot to update.
On 2015/03/13 11:41:37, Yang wrote: > On 2015/03/13 11:35:29, I haz the power (commit-bot) wrote: > > Try jobs failed on following builders: > > v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, > > > http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...) > > I think you either have to fix the call site in Blink or wait for the bot to > update. Blink just hasn't been rolled into Chromium for too long. So the change is in Blink but not in Chromium ToT, I was abusing CQ to check this a day after the change landed in Blink.
On 2015/03/13 13:45:29, yurys wrote: > On 2015/03/13 11:41:37, Yang wrote: > > On 2015/03/13 11:35:29, I haz the power (commit-bot) wrote: > > > Try jobs failed on following builders: > > > v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, > > > > > > http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...) > > > > I think you either have to fix the call site in Blink or wait for the bot to > > update. > > Blink just hasn't been rolled into Chromium for too long. So the change is in > Blink but not in Chromium ToT, I was abusing CQ to check this a day after the > change landed in Blink. Oh, there is one more usage of the method in Blink unit tests. Will update them first.
The CQ bit was checked by yurys@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997583004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...)
The CQ bit was checked by yurys@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997583004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...)
The CQ bit was checked by yurys@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997583004/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/f92c8a36709efb1514846b3bb672c40e4fb4c672 Cr-Commit-Position: refs/heads/master@{#27208}
Message was sent while issue was closed.
On 2015/03/16 09:49:35, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as > https://crrev.com/f92c8a36709efb1514846b3bb672c40e4fb4c672 > Cr-Commit-Position: refs/heads/master@{#27208} When removing deprecated functions in future, please add in the description what should be used instead.
Message was sent while issue was closed.
On 2015/06/15 11:44:15, ulan wrote: > On 2015/03/16 09:49:35, commit-bot: I haz the power wrote: > > Patchset 1 (id:??) landed as > > https://crrev.com/f92c8a36709efb1514846b3bb672c40e4fb4c672 > > Cr-Commit-Position: refs/heads/master@{#27208} > > When removing deprecated functions in future, please add in the description what > should be used instead. Sure. |