Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: include/v8-profiler.h

Issue 997583004: Remove obsolete TakeHeapSnapshot method from API (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8-profiler.h
diff --git a/include/v8-profiler.h b/include/v8-profiler.h
index 56b8e02616a2d4594a1cb606c91cfd718e1fe920..173849e0cd96a5d8a7c8d9b14359e8e84a56178e 100644
--- a/include/v8-profiler.h
+++ b/include/v8-profiler.h
@@ -447,16 +447,9 @@ class V8_EXPORT HeapProfiler {
};
/**
- * Takes a heap snapshot and returns it. Title parameter is deprecated and
- * should be an empty string.
- * TODO: deprecate this method.
+ * Takes a heap snapshot and returns it.
*/
const HeapSnapshot* TakeHeapSnapshot(
- Handle<String> title,
- ActivityControl* control = NULL,
- ObjectNameResolver* global_object_name_resolver = NULL);
-
- const HeapSnapshot* TakeHeapSnapshot(
ActivityControl* control = NULL,
ObjectNameResolver* global_object_name_resolver = NULL);
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698