Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 997543002: Removed bailout-only 'implementations' of intrinsics in Crankshaft. (Closed)

Created:
5 years, 9 months ago by Sven Panne
Modified:
5 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Removed bailout-only 'implementations' of intrinsics in Crankshaft. Doing a runtime call should always be better than totally giving up (unless we have fullcode-only intrinsics, which we'll probably never have). BUG=v8:3947 LOG=n Committed: https://crrev.com/db2d31ab3b8a51eeab1cd2c44dc9bb5151e9af97 Cr-Commit-Position: refs/heads/master@{#27110}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -127 lines) Patch
M src/bailout-reason.h View 1 chunk +0 lines, -11 lines 0 comments Download
M src/hydrogen.h View 1 chunk +68 lines, -75 lines 0 comments Download
M src/hydrogen.cc View 5 chunks +0 lines, -41 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
Sven Panne
5 years, 9 months ago (2015-03-10 13:46:14 UTC) #2
Michael Starzinger
LGTM (if it doesn't tank anything due to Crankshaft becoming "slower" than full-codegen on construed ...
5 years, 9 months ago (2015-03-10 13:52:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997543002/1
5 years, 9 months ago (2015-03-10 14:59:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 15:00:14 UTC) #6
Sven Panne
On 2015/03/10 13:52:16, Michael Starzinger wrote: > For posterity: These two might cause troubles, as ...
5 years, 9 months ago (2015-03-10 15:00:29 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 15:00:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db2d31ab3b8a51eeab1cd2c44dc9bb5151e9af97
Cr-Commit-Position: refs/heads/master@{#27110}

Powered by Google App Engine
This is Rietveld 408576698