 Chromium Code Reviews
 Chromium Code Reviews Issue 997543002:
  Removed bailout-only 'implementations' of intrinsics in Crankshaft.  (Closed) 
  Base URL: https://chromium.googlesource.com/v8/v8.git@master
    
  
    Issue 997543002:
  Removed bailout-only 'implementations' of intrinsics in Crankshaft.  (Closed) 
  Base URL: https://chromium.googlesource.com/v8/v8.git@master| Index: src/hydrogen.cc | 
| diff --git a/src/hydrogen.cc b/src/hydrogen.cc | 
| index 545031b7185648fcaa5b0e7798c89788f31792f6..124af1070a4f4cf6dbc9b7310fb8cb196ce9bb51 100644 | 
| --- a/src/hydrogen.cc | 
| +++ b/src/hydrogen.cc | 
| @@ -11606,11 +11606,6 @@ void HOptimizedGraphBuilder::GenerateHasFastPackedElements(CallRuntime* call) { | 
| } | 
| -void HOptimizedGraphBuilder::GenerateIsNonNegativeSmi(CallRuntime* call) { | 
| - return Bailout(kInlinedRuntimeFunctionIsNonNegativeSmi); | 
| -} | 
| - | 
| - | 
| void HOptimizedGraphBuilder::GenerateIsUndetectableObject(CallRuntime* call) { | 
| DCHECK(call->arguments()->length() == 1); | 
| CHECK_ALIVE(VisitForValue(call->arguments()->at(0))); | 
| @@ -11620,12 +11615,6 @@ void HOptimizedGraphBuilder::GenerateIsUndetectableObject(CallRuntime* call) { | 
| } | 
| -void HOptimizedGraphBuilder::GenerateIsStringWrapperSafeForDefaultValueOf( | 
| - CallRuntime* call) { | 
| - return Bailout(kInlinedRuntimeFunctionIsStringWrapperSafeForDefaultValueOf); | 
| -} | 
| - | 
| - | 
| // Support for construct call checks. | 
| void HOptimizedGraphBuilder::GenerateIsConstructCall(CallRuntime* call) { | 
| DCHECK(call->arguments()->length() == 0); | 
| @@ -11684,14 +11673,6 @@ void HOptimizedGraphBuilder::GenerateArguments(CallRuntime* call) { | 
| } | 
| -// Support for accessing the class and value fields of an object. | 
| -void HOptimizedGraphBuilder::GenerateClassOf(CallRuntime* call) { | 
| - // The special form detected by IsClassOfTest is detected before we get here | 
| - // and does not cause a bailout. | 
| - return Bailout(kInlinedRuntimeFunctionClassOf); | 
| -} | 
| - | 
| - | 
| void HOptimizedGraphBuilder::GenerateValueOf(CallRuntime* call) { | 
| DCHECK(call->arguments()->length() == 1); | 
| CHECK_ALIVE(VisitForValue(call->arguments()->at(0))); | 
| @@ -11996,12 +11977,6 @@ void HOptimizedGraphBuilder::GenerateCallFunction(CallRuntime* call) { | 
| } | 
| -void HOptimizedGraphBuilder::GenerateDefaultConstructorCallSuper( | 
| - CallRuntime* call) { | 
| - return Bailout(kSuperReference); | 
| -} | 
| - | 
| - | 
| // Fast call to math functions. | 
| void HOptimizedGraphBuilder::GenerateMathPow(CallRuntime* call) { | 
| DCHECK_EQ(2, call->arguments()->length()); | 
| @@ -12694,22 +12669,6 @@ void HOptimizedGraphBuilder::GenerateGetCachedArrayIndex(CallRuntime* call) { | 
| } | 
| -void HOptimizedGraphBuilder::GenerateFastOneByteArrayJoin(CallRuntime* call) { | 
| - return Bailout(kInlinedRuntimeFunctionFastOneByteArrayJoin); | 
| -} | 
| - | 
| - | 
| -// Support for generators. | 
| -void HOptimizedGraphBuilder::GenerateGeneratorNext(CallRuntime* call) { | 
| 
Michael Starzinger
2015/03/10 13:52:15
For posterity: These two might cause troubles, as
 | 
| - return Bailout(kInlinedRuntimeFunctionGeneratorNext); | 
| -} | 
| - | 
| - | 
| -void HOptimizedGraphBuilder::GenerateGeneratorThrow(CallRuntime* call) { | 
| - return Bailout(kInlinedRuntimeFunctionGeneratorThrow); | 
| -} | 
| - | 
| - | 
| void HOptimizedGraphBuilder::GenerateDebugBreakInOptimizedCode( | 
| CallRuntime* call) { | 
| Add<HDebugBreak>(); |