Fix uninitialized data in GpuChannelManagerTest::SecureValueStateForwarding.

Fix uninitialized data in GpuChannelManagerTest::SecureValueStateForwarding.

BUG=464836
Committed: https://crrev.com/72e357c0514b448a21d3a91f70768a54c33d3478
Cr-Commit-Position: refs/heads/master@{#319836}

[Ken Russell (switch to Gerrit), 2015-03-10 03:20:52]

kbr@chromium.org changed reviewers:
+ earthdok@chromium.org, thestig@chromium.org

[Ken Russell (switch to Gerrit), 2015-03-10 03:20:53]

PTAL

[Lei Zhang, 2015-03-10 03:36:26]

https://codereview.chromium.org/997433002/diff/1/content/common/gpu/gpu_chann...
File content/common/gpu/gpu_channel_manager_unittest.cc (right):

https://codereview.chromium.org/997433002/diff/1/content/common/gpu/gpu_chann...
content/common/gpu/gpu_channel_manager_unittest.cc:175: ValueState value_state1;
Doesn't ValueState also contain float float_value[4]; ?

[Ken Russell (switch to Gerrit), 2015-03-10 03:44:49]

On 2015/03/10 03:36:26, Lei Zhang wrote:
>
https://codereview.chromium.org/997433002/diff/1/content/common/gpu/gpu_chann...
> File content/common/gpu/gpu_channel_manager_unittest.cc (right):
> 
>
https://codereview.chromium.org/997433002/diff/1/content/common/gpu/gpu_chann...
> content/common/gpu/gpu_channel_manager_unittest.cc:175: ValueState
value_state1;
> Doesn't ValueState also contain float float_value[4]; ?

It's a union, so initializing either part should be sufficient.

I was also thinking about memset(&value_state1, 0, sizeof(value_state1)) and
similarly for value_state2.

I'm not sure why a simple union that doesn't have a constructor and initializer
was chosen here.

[Lei Zhang, 2015-03-10 04:09:52]

On 2015/03/10 03:44:49, Ken Russell wrote:
> On 2015/03/10 03:36:26, Lei Zhang wrote:
> >
>
https://codereview.chromium.org/997433002/diff/1/content/common/gpu/gpu_chann...
> > File content/common/gpu/gpu_channel_manager_unittest.cc (right):
> > 
> >
>
https://codereview.chromium.org/997433002/diff/1/content/common/gpu/gpu_chann...
> > content/common/gpu/gpu_channel_manager_unittest.cc:175: ValueState
> value_state1;
> > Doesn't ValueState also contain float float_value[4]; ?
> 
> It's a union, so initializing either part should be sufficient.

Ah yes, lgtm. I verified locally.

[Ken Russell (switch to Gerrit), 2015-03-10 04:11:56]

On 2015/03/10 04:09:52, Lei Zhang wrote:
> On 2015/03/10 03:44:49, Ken Russell wrote:
> > On 2015/03/10 03:36:26, Lei Zhang wrote:
> > >
> >
>
https://codereview.chromium.org/997433002/diff/1/content/common/gpu/gpu_chann...
> > > File content/common/gpu/gpu_channel_manager_unittest.cc (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/997433002/diff/1/content/common/gpu/gpu_chann...
> > > content/common/gpu/gpu_channel_manager_unittest.cc:175: ValueState
> > value_state1;
> > > Doesn't ValueState also contain float float_value[4]; ?
> > 
> > It's a union, so initializing either part should be sufficient.
> 
> Ah yes, lgtm. I verified locally.

Thanks.

[Ken Russell (switch to Gerrit), 2015-03-10 04:11:59]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2015-03-10 04:12:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/997433002/1

[commit-bot: I haz the power, 2015-03-10 04:39:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-10 04:39:38]

Patchset 1 (id:??) landed as
https://crrev.com/72e357c0514b448a21d3a91f70768a54c33d3478
Cr-Commit-Position: refs/heads/master@{#319836}