Fix uninitialized data in GpuChannelManagerTest::SecureValueStateForwarding.

content/common/gpu/gpu_channel_manager_unittest.cc

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/run_loop.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/test/test_simple_task_runner.h"
 #include "content/common/gpu/gpu_channel.h"
 #include "content/common/gpu/gpu_channel_manager.h"
 #include "content/common/gpu/gpu_messages.h"
@@ skipping 154 matching lines @@
   scoped_ptr<SimpleGpuClient> simple_client_;
   scoped_ptr<IPC::SimpleServer> simple_server_;
 
  private:
   base::MessageLoop message_loop_;
 };
 
 TEST_F(GpuChannelManagerTest, SecureValueStateForwarding) {
   const int kClientId1 = 111;
   const int kClientId2 = 222;
-  ValueState kValueState1;
-  kValueState1.int_value[0] = 1111;
-  ValueState kValueState2;
-  kValueState2.int_value[0] = 3333;
+  ValueState value_state1;

[Lei Zhang, 2015/03/10 03:36:26]

Doesn't ValueState also contain float float_value[4]; ?

+  value_state1.int_value[0] = 1111;
+  value_state1.int_value[1] = 0;
+  value_state1.int_value[2] = 0;
+  value_state1.int_value[3] = 0;
+  ValueState value_state2;
+  value_state2.int_value[0] = 3333;
+  value_state2.int_value[1] = 0;
+  value_state2.int_value[2] = 0;
+  value_state2.int_value[3] = 0;
 
   ASSERT_TRUE(simple_client_->gpu_channel_manager() != NULL);
 
   // Initialize gpu channels
   simple_client_->gpu_channel_manager()->OnMessageReceived(
       GpuMsg_EstablishChannel(kClientId1, false, false));
   GpuChannel *channel1 =
       simple_client_->gpu_channel_manager()->LookupChannel(kClientId1);
   simple_client_->gpu_channel_manager()->OnMessageReceived(
       GpuMsg_EstablishChannel(kClientId2, false, false));
   GpuChannel *channel2 =
       simple_client_->gpu_channel_manager()->LookupChannel(kClientId2);
   ASSERT_TRUE(channel1 != NULL);
   ASSERT_TRUE(channel2 != NULL);
   ASSERT_NE(channel1, channel2);
 
   // Make sure value states are only accessible by proper channels
   simple_client_->gpu_channel_manager()->OnMessageReceived(
       GpuMsg_UpdateValueState(
-          kClientId1, GL_MOUSE_POSITION_CHROMIUM, kValueState1));
+          kClientId1, GL_MOUSE_POSITION_CHROMIUM, value_state1));
   simple_client_->gpu_channel_manager()->OnMessageReceived(
       GpuMsg_UpdateValueState(
-          kClientId2, GL_MOUSE_POSITION_CHROMIUM, kValueState2));
+          kClientId2, GL_MOUSE_POSITION_CHROMIUM, value_state2));
 
   const gpu::ValueStateMap* pending_value_buffer_state1 =
       channel1->pending_valuebuffer_state();
   const gpu::ValueStateMap* pending_value_buffer_state2 =
       channel2->pending_valuebuffer_state();
   ASSERT_NE(pending_value_buffer_state1, pending_value_buffer_state2);
 
   const ValueState* state1 =
       pending_value_buffer_state1->GetState(GL_MOUSE_POSITION_CHROMIUM);
   const ValueState* state2 =
       pending_value_buffer_state2->GetState(GL_MOUSE_POSITION_CHROMIUM);
   ASSERT_NE(state1, state2);
 
-  ASSERT_EQ(state1->int_value[0], kValueState1.int_value[0]);
-  ASSERT_EQ(state2->int_value[0], kValueState2.int_value[0]);
+  ASSERT_EQ(state1->int_value[0], value_state1.int_value[0]);
+  ASSERT_EQ(state2->int_value[0], value_state2.int_value[0]);
   ASSERT_NE(state1->int_value[0], state2->int_value[0]);
 }
 
 }  // namespace content