Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2275)

Unified Diff: content/common/input/web_input_event_traits.cc

Issue 997283002: Coalesce async touch move events until the ack back from render (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Made changes based on comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/input/web_input_event_traits.cc
diff --git a/content/common/input/web_input_event_traits.cc b/content/common/input/web_input_event_traits.cc
index 6ca962b5720d9741d2b6bc4d4d251f7e9a86b9ec..f4b3207575d26ef0650171cb848c51e7ab44c8e2 100644
--- a/content/common/input/web_input_event_traits.cc
+++ b/content/common/input/web_input_event_traits.cc
@@ -478,8 +478,9 @@ bool WebInputEventTraits::IgnoresAckDisposition(const WebInputEvent& event) {
case WebInputEvent::GesturePinchEnd:
case WebInputEvent::TouchCancel:
return true;
+ // For all touchmove events, we always need an ACK back from render, and
+ // for uncancelable touch move, we will also send a fake ACK.
tdresser 2015/03/26 15:25:29 Hmmm, this is a bit confusing. (Sorry I didn't cat
lanwei 2015/03/27 04:39:42 Done.
case WebInputEvent::TouchStart:
- case WebInputEvent::TouchMove:
case WebInputEvent::TouchEnd:
return !static_cast<const WebTouchEvent&>(event).cancelable;
default:

Powered by Google App Engine
This is Rietveld 408576698