Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 997143003: Fix for conditional expressions (Closed)

Created:
5 years, 9 months ago by vsm
Modified:
5 years, 9 months ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fix comments #

Patch Set 3 : Fix comments and formatting #

Patch Set 4 : Add test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -78 lines) Patch
M lib/src/checker/resolver.dart View 1 1 chunk +19 lines, -1 line 0 comments Download
M test/checker/checker_test.dart View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
M test/codegen/expect/dart/_internal.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/dart/_native_typed_data.js View 3 chunks +3 lines, -3 lines 0 comments Download
M test/codegen/expect/dart/convert.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/dart/core.js View 6 chunks +6 lines, -6 lines 0 comments Download
M test/dart_codegen/expect/_internal/list.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/convert/html_escape.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/convert/json.dart View 14 chunks +27 lines, -27 lines 0 comments Download
M test/dart_codegen/expect/convert/latin1.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M test/dart_codegen/expect/convert/string_conversion.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M test/dart_codegen/expect/convert/utf.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M test/dart_codegen/expect/core/string.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/core/uri.dart View 15 chunks +27 lines, -27 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
vsm
5 years, 9 months ago (2015-03-16 12:32:55 UTC) #2
vsm
https://codereview.chromium.org/997143003/diff/1/lib/src/checker/resolver.dart File lib/src/checker/resolver.dart (right): https://codereview.chromium.org/997143003/diff/1/lib/src/checker/resolver.dart#newcode404 lib/src/checker/resolver.dart:404: // null literal. I think the better fix would ...
5 years, 9 months ago (2015-03-16 13:20:54 UTC) #4
vsm
https://codereview.chromium.org/997143003/diff/1/lib/src/checker/resolver.dart File lib/src/checker/resolver.dart (right): https://codereview.chromium.org/997143003/diff/1/lib/src/checker/resolver.dart#newcode404 lib/src/checker/resolver.dart:404: // null literal. On 2015/03/16 13:20:54, vsm wrote: > ...
5 years, 9 months ago (2015-03-16 13:44:59 UTC) #5
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/997143003/diff/1/lib/src/checker/resolver.dart File lib/src/checker/resolver.dart (right): https://codereview.chromium.org/997143003/diff/1/lib/src/checker/resolver.dart#newcode420 lib/src/checker/resolver.dart:420: // TODO(vsm): in visitConditionalExpression: check... LUB in rules? ...
5 years, 9 months ago (2015-03-16 15:11:40 UTC) #6
vsm
https://codereview.chromium.org/997143003/diff/1/lib/src/checker/resolver.dart File lib/src/checker/resolver.dart (right): https://codereview.chromium.org/997143003/diff/1/lib/src/checker/resolver.dart#newcode420 lib/src/checker/resolver.dart:420: // TODO(vsm): in visitConditionalExpression: check... LUB in rules? On ...
5 years, 9 months ago (2015-03-16 15:30:39 UTC) #7
vsm
5 years, 9 months ago (2015-03-16 17:09:33 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
86147678021fcd6400cdf229a67b0f9f0fab8af1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698