Fix for conditional expressions

lib/src/codegen/js_codegen.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dev_compiler.src.codegen.js_codegen;
 
 import 'dart:collection' show HashSet;
 import 'dart:io' show Directory, File;
 
 import 'package:analyzer/analyzer.dart' hide ConstantEvaluator;
@@ skipping 942 matching lines @@
       //    var result = [];
       //    result.length = length;
       var savedCascadeTemp = _cascadeTarget;
       _cascadeTarget = last.name;
 
       variables = _visitList(node.variables.take(node.variables.length - 1));
       variables.add(new JS.VariableInitialization(
           new JS.VariableDeclaration(last.name.name),
           _visit(lastInitializer.target)));
 
-      var result =
-          <JS.Expression>[new JS.VariableDeclarationList('let', variables)];
+      var result = <JS.Expression>[

[Siggi Cherem (dart-lang), 2015/03/16 15:11:40]

I think you might have an older version of the formatter, if you do pub-upgrade,
does this change go away?

Maybe what we could do going forward is to pin a very specific version of the
formatter, rather than a range of versions.

[vsm, 2015/03/16 15:30:38]

You are right.  Upgrading and rerunning.  We probably should pin.

+        new JS.VariableDeclarationList('let', variables)
+      ];
       result.addAll(_visitList(lastInitializer.cascadeSections));
       _cascadeTarget = savedCascadeTemp;
       return _statement(result.map((e) => new JS.ExpressionStatement(e)));
     } else {
       variables = _visitList(node.variables);
     }
 
     return new JS.VariableDeclarationList('let', variables);
   }
 
@@ skipping 34 matching lines @@
             isSetter: true));
       }
     }
 
     return js.statement(
         'dart.defineLazyProperties(#, { # })', [objExpr, methods]);
   }
 
   void _flushLibraryProperties(List<JS.Statement> body) {
     if (_properties.isEmpty) return;
-    body.add(js.statement('dart.copyProperties($_EXPORTS, { # });',
-        [_properties.map(_emitTopLevelProperty)]));
+    body.add(js.statement('dart.copyProperties($_EXPORTS, { # });', [
+      _properties.map(_emitTopLevelProperty)
+    ]));
     _properties.clear();
   }
 
   @override
   JS.Statement visitVariableDeclarationStatement(
           VariableDeclarationStatement node) =>
       _expressionStatement(_visit(node.variables));
 
   @override
   visitConstructorName(ConstructorName node) {
@@ skipping 571 matching lines @@
 
   @override
   visitDoubleLiteral(DoubleLiteral node) => js.number(node.value);
 
   @override
   visitNullLiteral(NullLiteral node) => new JS.LiteralNull();
 
   @override
   visitListLiteral(ListLiteral node) {
     // TODO(jmesserly): make this faster. We're wasting an array.
-    var list = js.call('new List.from(#)',
-        [new JS.ArrayInitializer(_visitList(node.elements))]);
+    var list = js.call('new List.from(#)', [
+      new JS.ArrayInitializer(_visitList(node.elements))
+    ]);
     if (node.constKeyword != null) {
       list = js.commentExpression('Unimplemented const', list);
     }
     return list;
   }
 
   @override
   visitMapLiteral(MapLiteral node) {
     var entries = node.entries;
     var mapArguments = null;
@@ skipping 305 matching lines @@
       CheckerReporter reporter) {
     JS.Program jsTree =
         new JSCodegenVisitor(info, rules).generateLibrary(units, reporter);
 
     var outputPath = path.join(outDir, jsOutputPath(info, root));
     new Directory(path.dirname(outputPath)).createSync(recursive: true);
 
     if (options.emitSourceMaps) {
       var outFilename = path.basename(outputPath);
       var printer = new srcmaps.Printer(outFilename);
-      _writeNode(
-          new SourceMapPrintingContext(printer, path.dirname(outputPath)),
-          jsTree);
+      _writeNode(new SourceMapPrintingContext(
+          printer, path.dirname(outputPath)), jsTree);
       printer.add('//# sourceMappingURL=$outFilename.map');
       // Write output file and source map
       var text = printer.text;
       new File(outputPath).writeAsStringSync(text);
       new File('$outputPath.map').writeAsStringSync(printer.map);
       return computeHash(text);
     } else {
       var text = jsNodeToString(jsTree);
       new File(outputPath).writeAsStringSync(text);
       return computeHash(text);
@@ skipping 87 matching lines @@
 
     // TODO(jmesserly): in many cases marking the end will be unncessary.
     printer.mark(_location(node.end));
   }
 
   String _getIdentifier(AstNode node) {
     if (node is SimpleIdentifier) return node.name;
     return null;
   }
 }