Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 997003004: [bindings] Migrate V8TestingScope out of V8Binding.h/cpp (Closed)

Created:
5 years, 9 months ago by vivekg_samsung
Modified:
5 years, 9 months ago
Reviewers:
haraken, vivekg
CC:
vivekg, darktears, arv+blink, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-bindings_chromium.org, cmumford, dgrogan, dstockwell, Eric Willigers, jsbell+idb_chromium.org, Mike Lawther (Google), rjwright, shans, Steve Block, Timothy Loh, tyoshino+watch_chromium.org, vivekg_samsung, yhirano+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[bindings] Migrate V8TestingScope out of V8Binding.h/cpp V8TestingScope is used by various tests. Ideally this belong to a separate test specific files. Migrate these bits out of V8Binding.h/cpp. R=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191992

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -36 lines) Patch
M Source/bindings/core/v8/ScriptPromiseTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/core/v8/ScriptStreamerTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/core/v8/SerializedScriptValueTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/core/v8/ToV8Test.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/core/v8/V8Binding.h View 1 chunk +0 lines, -13 lines 0 comments Download
M Source/bindings/core/v8/V8Binding.cpp View 1 chunk +0 lines, -23 lines 0 comments Download
M Source/bindings/core/v8/V8BindingTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/core/v8/V8ScriptRunnerTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
A Source/bindings/core/v8/V8TestingScope.h View 1 chunk +29 lines, -0 lines 0 comments Download
A Source/bindings/core/v8/V8TestingScope.cpp View 1 chunk +35 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/v8.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/modules/v8/V8BindingForModulesTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/animation/AnimationTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/animation/EffectInputTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/animation/TimingInputTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/testing/PrivateScriptTestTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/indexeddb/IDBRequestTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/indexeddb/IDBTransactionTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/websockets/DOMWebSocketTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/tests/CustomEventTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/tests/PageSerializerTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
vivekg
PTAL, thanks.
5 years, 9 months ago (2015-03-17 07:03:58 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-17 08:10:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997003004/1
5 years, 9 months ago (2015-03-17 08:11:46 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 09:52:17 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191992

Powered by Google App Engine
This is Rietveld 408576698