Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: Source/bindings/core/v8/V8Binding.cpp

Issue 997003004: [bindings] Migrate V8TestingScope out of V8Binding.h/cpp (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/V8Binding.h ('k') | Source/bindings/core/v8/V8BindingTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8Binding.cpp
diff --git a/Source/bindings/core/v8/V8Binding.cpp b/Source/bindings/core/v8/V8Binding.cpp
index 0f8d64c7f9f1fb2f4e19bbb1093a8014f51af597..fd1c69455c364bc499554d79c0eae56caab5ffd2 100644
--- a/Source/bindings/core/v8/V8Binding.cpp
+++ b/Source/bindings/core/v8/V8Binding.cpp
@@ -952,29 +952,6 @@ PassRefPtr<JSONValue> v8ToJSONValue(v8::Isolate* isolate, v8::Handle<v8::Value>
return nullptr;
}
-V8TestingScope::V8TestingScope(v8::Isolate* isolate)
- : m_handleScope(isolate)
- , m_contextScope(v8::Context::New(isolate))
- // We reuse the main world since the main world is guaranteed to be registered to ScriptController.
- , m_scriptState(ScriptStateForTesting::create(isolate->GetCurrentContext(), &DOMWrapperWorld::mainWorld()))
-{
-}
-
-V8TestingScope::~V8TestingScope()
-{
- m_scriptState->disposePerContextData();
-}
-
-ScriptState* V8TestingScope::scriptState() const
-{
- return m_scriptState.get();
-}
-
-v8::Isolate* V8TestingScope::isolate() const
-{
- return m_scriptState->isolate();
-}
-
void DevToolsFunctionInfo::ensureInitialized() const
{
if (m_function.IsEmpty())
« no previous file with comments | « Source/bindings/core/v8/V8Binding.h ('k') | Source/bindings/core/v8/V8BindingTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698