Dart: Better handle leak checks. close() is async.

mojo/dart/embedder/isolate_data.h

Index: mojo/dart/embedder/isolate_data.h
diff --git a/mojo/dart/embedder/isolate_data.h b/mojo/dart/embedder/isolate_data.h
index bd29fe1ab2b2fef266f55806abb1c5d76f4a454a..69fd093d7719fe1a1ae6f1977aaefa5e0d944bf0 100644
--- a/mojo/dart/embedder/isolate_data.h
+++ b/mojo/dart/embedder/isolate_data.h
@@ -5,8 +5,7 @@
 #ifndef MOJO_DART_EMBEDDER_ISOLATE_DATA_H_
 #define MOJO_DART_EMBEDDER_ISOLATE_DATA_H_
 
-#include <stdlib.h>
-#include <string.h>

[sky, 2015/03/11 17:17:57]

AFAIK if you use std::string then you should include <string>

[zra, 2015/03/11 18:58:19]

Added.

+#include <set>
 
 #include "base/callback.h"
 #include "base/macros.h"
@@ -43,6 +42,7 @@ class IsolateData {
   std::string script;
   std::string script_uri;
   std::string package_root;
+  std::set<int64_t> unclosed_handles;

[sky, 2015/03/11 17:17:57]

Is there a reason you don't make this MojoHandle?

[zra, 2015/03/11 18:58:20]

Ah. I was apparently trying to avoid some extra casting code at use sites, but
on second look that doesn't make sense. Changed to MojoHandle.

 
   DISALLOW_COPY_AND_ASSIGN(IsolateData);
 };