Dart: Better handle leak checks. close() is async.

mojo/dart/embedder/isolate_data.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MOJO_DART_EMBEDDER_ISOLATE_DATA_H_
 #define MOJO_DART_EMBEDDER_ISOLATE_DATA_H_
 
-#include <stdlib.h>
-#include <string.h>

[sky, 2015/03/11 17:17:57]

AFAIK if you use std::string then you should include <string>

[zra, 2015/03/11 18:58:19]

Added.

+#include <set>
 
 #include "base/callback.h"
 #include "base/macros.h"
 #include "dart/runtime/include/dart_api.h"
 
 namespace mojo {
 namespace dart {
 
 struct IsolateCallbacks {
   base::Callback<Dart_Isolate(const char*,const char*,const char*,void*,char**)>
@@ skipping 16 matching lines @@
         script(script),
         script_uri(script_uri),
         package_root(package_root) {}
 
   void* app;
   bool strict_compilation;
   IsolateCallbacks callbacks;
   std::string script;
   std::string script_uri;
   std::string package_root;
+  std::set<int64_t> unclosed_handles;

[sky, 2015/03/11 17:17:57]

Is there a reason you don't make this MojoHandle?

[zra, 2015/03/11 18:58:20]

Ah. I was apparently trying to avoid some extra casting code at use sites, but
on second look that doesn't make sense. Changed to MojoHandle.

 
   DISALLOW_COPY_AND_ASSIGN(IsolateData);
 };
 
 }  // namespace dart
 }  // namespace mojo
 
 #endif  // MOJO_DART_EMBEDDER_ISOLATE_DATA_H_