Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: examples/dart/wget/main.dart

Issue 996923003: Dart: Better handle leak checks. close() is async. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Fix regexes Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: examples/dart/wget/main.dart
diff --git a/examples/dart/wget/main.dart b/examples/dart/wget/main.dart
index 17c0e678302ecda26e50fd2bf1317a864e4bd786..2e0df99e6f854ef29afde58de0220df780e3909b 100644
--- a/examples/dart/wget/main.dart
+++ b/examples/dart/wget/main.dart
@@ -35,15 +35,16 @@ class WGet extends Application {
print(">>> EOF <<<");
_closeProxies();
- close();
+ await close();
+ assert(MojoHandle.reportLeakedHandles());
}
Future<ByteData> _getUrl(String url) async {
_initProxiesIfNeeded();
var urlRequest = new UrlRequest()
- ..url = url
- ..autoFollowRedirects = true;
+ ..url = url
+ ..autoFollowRedirects = true;
var urlResponse = await _urlLoader.ptr.start(urlRequest);
print(">>> Headers <<<");

Powered by Google App Engine
This is Rietveld 408576698