Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Unified Diff: examples/dart/console_example/main.dart

Issue 996923003: Dart: Better handle leak checks. close() is async. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Fix regexes Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | examples/dart/hello_world/hello/main.dart » ('j') | mojo/dart/embedder/isolate_data.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: examples/dart/console_example/main.dart
diff --git a/examples/dart/console_example/main.dart b/examples/dart/console_example/main.dart
index 9e04850a008f9e437ca62ceefac8f051f71c1ccd..c4029bb10c4d27d10e18401b01fb681e8a759a27 100644
--- a/examples/dart/console_example/main.dart
+++ b/examples/dart/console_example/main.dart
@@ -25,7 +25,8 @@ class ConsoleApplication extends Application {
await _console.ptr.printLines([result.line]);
_console.close();
- close();
+ await close();
+ assert(MojoHandle.reportLeakedHandles());
}
}
« no previous file with comments | « no previous file | examples/dart/hello_world/hello/main.dart » ('j') | mojo/dart/embedder/isolate_data.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698