Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 996723002: Fix and re-enable v8.top_25_smooth (Closed)

Created:
5 years, 9 months ago by ssid
Modified:
5 years, 9 months ago
Reviewers:
picksi, rmcilroy, picksi1, Sami
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix and re-enable v8.top_25_smooth The test was checking for resources that did not load. Added wait for the page to complete loading and then run actions. BUG=465446 Committed: https://crrev.com/acac16b3abdc5abd3408d2e2a58c4d8a60def7d8 Cr-Commit-Position: refs/heads/master@{#320104}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M tools/perf/page_sets/top_25_smooth.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/perf/page_sets/top_pages.py View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
ssid
PTAL.
5 years, 9 months ago (2015-03-11 10:27:02 UTC) #2
picksi
Looks good. One typo nit. https://codereview.chromium.org/996723002/diff/1/tools/perf/page_sets/top_pages.py File tools/perf/page_sets/top_pages.py (right): https://codereview.chromium.org/996723002/diff/1/tools/perf/page_sets/top_pages.py#newcode57 tools/perf/page_sets/top_pages.py:57: # This check is ...
5 years, 9 months ago (2015-03-11 11:12:39 UTC) #4
ssid
Done.
5 years, 9 months ago (2015-03-11 11:27:26 UTC) #5
Sami
Thanks, lgtm.
5 years, 9 months ago (2015-03-11 13:55:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/996723002/20001
5 years, 9 months ago (2015-03-11 14:10:25 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-11 17:43:12 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 17:43:54 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/acac16b3abdc5abd3408d2e2a58c4d8a60def7d8
Cr-Commit-Position: refs/heads/master@{#320104}

Powered by Google App Engine
This is Rietveld 408576698