tools/perf/page_sets/top_pages.py - Issue 996723002: Fix and re-enable v8.top_25_smooth

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/top_pages.py

Issue 996723002: Fix and re-enable v8.top_25_smooth (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed comment. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/page_sets/top_pages.py

diff --git a/tools/perf/page_sets/top_pages.py b/tools/perf/page_sets/top_pages.py

index 95caa53920d702b4698ed397a0eb653dc9e09b72..5ecfe4b735385dc68c9a5d13cd421e3af16997d3 100644

--- a/tools/perf/page_sets/top_pages.py

+++ b/tools/perf/page_sets/top_pages.py

@@ -54,6 +54,9 @@ class GmailPage(TopPages):

action_runner.WaitForJavaScriptCondition(

'window.gmonkey !== undefined &&'

'document.getElementById("gb") !== null')

+ # This check is needed for gmonkey to load completely.

+ action_runner.WaitForJavaScriptCondition(

+ 'document.readyState == "complete"')

class GoogleCalendarPage(TopPages):

« no previous file with comments | « tools/perf/page_sets/top_25_smooth.py ('k') | no next file » | no next file with comments »