Avoid layout/full-repaint on view height change if possible

Source/core/rendering/RenderView.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 1217 matching lines @@
     return std::min(viewLogicalWidth(ScrollableArea::IncludeScrollbars), viewLogicalHeight(ScrollableArea::IncludeScrollbars))
         * percentage / 100.f;
 }
 
 LayoutUnit RenderView::viewportPercentageMax(float percentage) const
 {
     return std::max(viewLogicalWidth(ScrollableArea::IncludeScrollbars), viewLogicalHeight(ScrollableArea::IncludeScrollbars))
         * percentage / 100.f;
 }
 
+void RenderView::viewResized()
+{
+    if (logicalWidth() != viewLogicalWidth() || needsLayoutOnLogicalHeightChange()) {
+        setNeedsLayout();
+    } else if (!needsLayout()) {
+        setLogicalHeight(viewLogicalHeight());
+        if (m_overflow)
+            m_overflow->setVisualOverflow(borderBoxRect());
+        layer()->updateLayerPositionsAfterLayout(layer(), RenderLayer::defaultFlags);
+    }
+}
+
+bool RenderView::needsLayoutOnLogicalHeightChange() const
+{
+    // FIXME: Move logics that are generic to RenderBox or RenderBlock into these classes
+    // so that this function can be also used to optimize layout of them.
+
+    if (document().inQuirksMode() || document().paginated() || shouldUsePrintingLayout())
+        return true;
+
+    // Optimize layout in horizontal writing mode only to simplify the logic.
+    if (!style()->isHorizontalWritingMode())
+        return true;
+
+    if (hasPercentHeightDescendants())
+        return true;
+
+    if (document().ensureStyleResolver().affectedByViewportChange())
+        return true;
+
+    // FIXME: Waiting for document().hasViewportUnits().
+    // if (document().hasViewportUnits())

[ojan, 2014/01/03 02:04:26]

We generally don't commit commented out code. In this case, you can just have
the FIXME.

Until this is fixed, doesn't this mean that we'll do the wrong thing in a
document that uses viewport units?

Can you add hasViewportUnits in a patch first and then we can commit this one?
Otherwise, I think we should add back in the runtime flag. I was hoping we
wouldn't need the flag since we could get all the functionality in one patch,
but if we need to do it in multiple patches we need the flag. 

[Xianzhu, 2014/01/03 20:46:24]

I meant this patch depends on https://codereview.chromium.org/82083002/. Timloh@
submitted that change yesterday so I can remove the FIXME and uncomment the code
now :)

+    //     return true;
+
+    // Needs layout if there is no body element (e.g. there is frameset).
+    Element* body = document().body();
+    if (!body || !body->hasTagName(HTMLNames::bodyTag))
+        return true;
+
+    // Root background image may be stretched related to the viewport size.
+    Element* documentElement = document().documentElement();
+    if (!documentElement || !documentElement->renderer()
+        || documentElement->renderer()->rendererForRootBackground()->style()->hasBackgroundImage())
+        return true;
+
+    if (TrackedRendererListHashSet* positionedObjects = this->positionedObjects()) {
+        TrackedRendererListHashSet::iterator end = positionedObjects->end();
+        for (TrackedRendererListHashSet::iterator it = positionedObjects->begin(); it != end; ++it) {
+            if ((*it)->node() && (*it)->node()->hasTagName(HTMLNames::dialogTag))
+                return true;
+
+            RenderStyle* childStyle = (*it)->style();
+            // Fixed position element may change compositing state when viewport height changes.
+            if (childStyle->position() == FixedPosition)
+                return true;
+            if (childStyle->top().isPercent() || childStyle->height().isPercent() || childStyle->minHeight().isPercent() || childStyle->maxHeight().isPercent() || !childStyle->bottom().isAuto())
+                return true;
+        }
+    }
+
+    return false;
+}
+
 FragmentationDisabler::FragmentationDisabler(RenderObject* root)
 {
     RenderView* renderView = root->view();
     ASSERT(renderView);
 
     LayoutState* layoutState = renderView->layoutState();
 
     m_root = root;
     m_fragmenting = layoutState && layoutState->isPaginated();
     m_flowThreadState = m_root->flowThreadState();
@@ skipping 19 matching lines @@
 #endif
 
     if (layoutState)
         layoutState->m_isPaginated = m_fragmenting;
 
     if (m_flowThreadState != RenderObject::NotInsideFlowThread)
         m_root->setFlowThreadStateIncludingDescendants(m_flowThreadState);
 }
 
 } // namespace WebCore