Run dartanalyze on the dartzip file structure.

Run dartanalyze on the dartzip file structure, by default.

This patch relands b905249b657b3ff373878a8756e2bde47e1289e6, which
enabled running dartanalyze by default, and hopefully fixes the problems
seen in that first run:

Instead of setting --package-root to the current build's out/.../gen/
dir, after building the dartzip file, unzip it to a temporary directory
and then run the analyzer on that.

a) This allows us to check that all dependencies are actually expressed
   in build rules.

b) This lets us run the dartanalyze in other repositories. (We may be
   consuming dartzips in repository B which were generated in repository
   A.)

c) This keeps us from being tied to the build output of one repository.

BUG=459376
R=tonyg@chromium.org, zra@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/62e312b60088f007e0296ad0a9607e78fd448392

[Elliot Glaysher, 2015-03-09 21:31:45]

erg@chromium.org changed reviewers:
+ tonyg@chromium.org

[Elliot Glaysher, 2015-03-09 21:31:46]

OK, learning from my first attempt to turn dartanalyze on by default. This
should fix the problems that caused me to revert the patch almost immediately.

[Elliot Glaysher, 2015-03-09 21:37:08]

erg@chromium.org changed reviewers:
+ zra@google.com

[Elliot Glaysher, 2015-03-09 21:37:26]

+zra, to verify that what I'm doing with the url-mapping commands is ok.

[tonyg, 2015-03-09 21:44:21]

lgtm, but it does seem like a good idea to wait for zra

https://codereview.chromium.org/996483003/diff/1/mojo/public/tools/dart_analy...
File mojo/public/tools/dart_analyze.py (right):

https://codereview.chromium.org/996483003/diff/1/mojo/public/tools/dart_analy...
mojo/public/tools/dart_analyze.py:17: import shutil
nit: alphabetize

https://codereview.chromium.org/996483003/diff/1/mojo/public/tools/dart_analy...
mojo/public/tools/dart_analyze.py:33: dartzip_file = args.pop(0)
This existed before your patch, but argparse.ArgumentParser() would make for
readable error messages in case this is used improperly.

https://codereview.chromium.org/996483003/diff/1/mojo/public/tools/dart_analy...
mojo/public/tools/dart_analyze.py:39: unzip_command = ['unzip', '-o', '-q',
dartzip_file, '-d', temp_dir]
Using python's zipfile package would make this code portable which'll probably
be useful eventually.

[zra, 2015-03-09 21:47:46]

lgtm

On 2015/03/09 21:37:26, Elliot Glaysher wrote:
> +zra, to verify that what I'm doing with the url-mapping commands is ok.

Yes. I see why you need to do it this way. My plan is to move the libraries that
depend on these 'package:' imports outside of the snapshot, which will remove
the need for these special cases. Until then, I think using --url-mapping is
okay.

[Elliot Glaysher, 2015-03-09 22:18:48]

tony: did the imports and the use of the zipfile module, but:

https://codereview.chromium.org/996483003/diff/1/mojo/public/tools/dart_analy...
File mojo/public/tools/dart_analyze.py (right):

https://codereview.chromium.org/996483003/diff/1/mojo/public/tools/dart_analy...
mojo/public/tools/dart_analyze.py:33: dartzip_file = args.pop(0)
On 2015/03/09 21:44:21, tonyg wrote:
> This existed before your patch, but argparse.ArgumentParser() would make for
> readable error messages in case this is used improperly.

I'm not entirely sure how to do this because they're *everything* is a
positional argument, and the other args are listed multiple times. I'm going to
punt on this one.

[Elliot Glaysher, 2015-03-09 22:19:48]

Committed patchset #2 (id:20001) manually as
62e312b60088f007e0296ad0a9607e78fd448392 (presubmit successful).