Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: BUILD.gn

Issue 996483003: Run dartanalyze on the dartzip file structure. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: most of tonyg's nits. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/public/dart/rules.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index fa8060bda59794c60b296e12ee43a45892a3b513..bdb6bb2d382c9d9d27576543778b06e70c8c73d7 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -25,24 +25,6 @@ group("default") {
}
}
-# A group which invokes the dart checker on each dart package. This can take
-# multiple seconds per target, so we separate it out from the main building.
-# Eventually, we'd like this to be part of the default dart building, but for
-# now, to participate in checking, please add "{package_name}_analyze" to the
-# list of dependencies below.
-group("dartcheck") {
- testonly = true
- deps = [
- "//examples/dart/console_example:console_example_analyze",
- "//examples/dart/hello_world/hello:hello_analyze",
- "//examples/dart/hello_world/world:world_analyze",
- "//examples/dart/wget:wget_analyze",
- "//services/dart/test/echo:echo_analyze",
- "//services/dart/test/pingpong:pingpong_analyze",
- "//services/dart/test/pingpong_target:pingpong_target_analyze",
- ]
-}
-
# Deprecated name for the default build target.
group("root") {
testonly = true
« no previous file with comments | « no previous file | mojo/public/dart/rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698