Simplify clip inside a layer -- will be applied in restore

Simplify clip inside a layer -- will be applied in restore

This reverts commit 44124650895833378938b4b174302fbf64403fe2.

NOTREECHECKS=True
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/180aec43451dd951fdaae81a92efc710ba093260

[reed1, 2015-03-11 14:42:54]

reed@google.com changed reviewers:
+ robertphillips@google.com

[reed1, 2015-03-11 14:42:55]

Needs https://codereview.chromium.org/993993003 to land in chrome (next blink
roll)

[robertphillips, 2015-03-11 16:06:38]

It looks good to me but I would find a GM very comforting.

https://codereview.chromium.org/996233002/diff/1/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/996233002/diff/1/src/core/SkCanvas.cpp#newcod...
src/core/SkCanvas.cpp:864: fClipStack->clipDevRect(ir, SkRegion::kReplace_Op);
I don't think ir can be empty - remove this code?

[reed1, 2015-03-11 17:02:52]

https://codereview.chromium.org/996233002/diff/1/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/996233002/diff/1/src/core/SkCanvas.cpp#newcod...
src/core/SkCanvas.cpp:864: fClipStack->clipDevRect(ir, SkRegion::kReplace_Op);
On 2015/03/11 16:06:38, robertphillips wrote:
> I don't think ir can be empty - remove this code?

I'll make a new CL that asserts that it is non-empty

[reed1, 2015-03-11 17:20:29]

ptal -- now w/ assert

[reed1, 2015-03-11 17:20:32]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2015-03-11 17:23:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/996233002/40001

[commit-bot: I haz the power, 2015-03-11 17:23:10]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-03-11 23:23 UTC

[robertphillips, 2015-03-11 17:29:26]

lgtm

[reed1, 2015-03-11 17:30:59]

The CQ bit was unchecked by reed@google.com

[reed1, 2015-03-11 17:31:03]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2015-03-11 17:31:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/996233002/40001

[reed1, 2015-03-11 17:33:22]

The CQ bit was unchecked by reed@google.com

[reed1, 2015-03-11 17:33:35]

The CQ bit was checked by reed@google.com

[reed1, 2015-03-11 17:33:39]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2015-03-11 17:33:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/996233002/40001

[reed1, 2015-03-11 17:36:42]

The CQ bit was unchecked by reed@google.com

[reed1, 2015-03-11 17:36:49]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2015-03-11 17:37:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/996233002/40001

[commit-bot: I haz the power, 2015-03-11 17:37:45]

The CQ bit was unchecked by commit-bot@chromium.org

[reed1, 2015-03-11 17:38:42]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2015-03-11 17:38:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/996233002/40001

[commit-bot: I haz the power, 2015-03-11 17:39:10]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/180aec43451dd951fdaae81a92efc710ba093260