|
|
Descriptionadd suppressions for bug 466090
BUG=
NOTRY=True
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191708
Patch Set 1 #
Total comments: 3
Patch Set 2 : remove flake #Messages
Total messages: 15 (5 generated)
reed@google.com changed reviewers: + fmalita@chromium.org
taken from here after attempting the skia change http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/5...
The CQ bit was checked by reed@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/993993003/1
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm % svg/custom/massive-coordinates.svg https://codereview.chromium.org/993993003/diff/1/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/993993003/diff/1/LayoutTests/TestExpectations... LayoutTests/TestExpectations:1416: crbug.com/466090 [ Release ] svg/custom/massive-coordinates.svg [ NeedsManualRebaseline ] This one is unrelated - it's been flaky for a while (listed under "ignored:" in the bot output).
https://codereview.chromium.org/993993003/diff/1/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/993993003/diff/1/LayoutTests/TestExpectations... LayoutTests/TestExpectations:1416: crbug.com/466090 [ Release ] svg/custom/massive-coordinates.svg [ NeedsManualRebaseline ] On 2015/03/11 14:19:33, f(malita) wrote: > This one is unrelated - it's been flaky for a while (listed under "ignored:" in > the bot output). svg/custom/massive-coordinates.svg ? should I just remove it from my CL?
On 2015/03/11 14:29:55, reed1 wrote: > https://codereview.chromium.org/993993003/diff/1/LayoutTests/TestExpectations > File LayoutTests/TestExpectations (right): > > https://codereview.chromium.org/993993003/diff/1/LayoutTests/TestExpectations... > LayoutTests/TestExpectations:1416: crbug.com/466090 [ Release ] > svg/custom/massive-coordinates.svg [ NeedsManualRebaseline ] > On 2015/03/11 14:19:33, f(malita) wrote: > > This one is unrelated - it's been flaky for a while (listed under "ignored:" > in > > the bot output). > > svg/custom/massive-coordinates.svg ? > should I just remove it from my CL? Yes. ( it's hinted in the bot output that it is failing with and w/o the patch: ignored: svg/custom/massive-coordinates.svg )
https://codereview.chromium.org/993993003/diff/1/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/993993003/diff/1/LayoutTests/TestExpectations... LayoutTests/TestExpectations:1416: crbug.com/466090 [ Release ] svg/custom/massive-coordinates.svg [ NeedsManualRebaseline ] On 2015/03/11 14:19:33, f(malita) wrote: > This one is unrelated - it's been flaky for a while (listed under "ignored:" in > the bot output). Done.
The CQ bit was checked by reed@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org Link to the patchset: https://codereview.chromium.org/993993003/#ps20001 (title: "remove flake")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/993993003/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=191708 |