Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 996173004: Convert more isolate files to respect use_x11 for Xvfb usage (Closed)

Created:
5 years, 9 months ago by spang
Modified:
5 years, 9 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, extensions-reviews_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, piman+watch_chromium.org, chromium-apps-reviews_chromium.org, cc-bugs_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert more isolate files to respect use_x11 for Xvfb usage This is a followup to the update to disable Xvfb for OS=="linux" use_x11==0 that converts additional targets. BUG=440882 TEST=isolate.py run -s out_ozone/Debug/<various> TBR=maruel Committed: https://crrev.com/c88a0abfe3d8ce136bdcef4b6f7f537df89bf72d Cr-Commit-Position: refs/heads/master@{#320143}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -179 lines) Patch
M cc/cc_unittests.isolate View 3 chunks +21 lines, -26 lines 0 comments Download
M components/components_browsertests.isolate View 2 chunks +18 lines, -18 lines 0 comments Download
M components/components_unittests.isolate View 3 chunks +31 lines, -30 lines 0 comments Download
M crypto/crypto_unittests.isolate View 2 chunks +14 lines, -14 lines 1 comment Download
M extensions/extensions_browsertests.isolate View 2 chunks +28 lines, -22 lines 0 comments Download
M gpu/gpu_unittests.isolate View 2 chunks +11 lines, -24 lines 0 comments Download
M media/cast/cast_unittests.isolate View 3 chunks +17 lines, -17 lines 0 comments Download
M media/media_unittests.isolate View 3 chunks +29 lines, -28 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
spang
5 years, 9 months ago (2015-03-11 18:29:34 UTC) #2
M-A Ruel
lgtm https://codereview.chromium.org/996173004/diff/1/crypto/crypto_unittests.isolate File crypto/crypto_unittests.isolate (right): https://codereview.chromium.org/996173004/diff/1/crypto/crypto_unittests.isolate#newcode6 crypto/crypto_unittests.isolate:6: ['use_x11==0', { This one probably doesn't need X ...
5 years, 9 months ago (2015-03-11 18:31:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/996173004/1
5 years, 9 months ago (2015-03-11 18:33:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/996173004/1
5 years, 9 months ago (2015-03-11 19:38:21 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-11 20:52:16 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 20:53:17 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c88a0abfe3d8ce136bdcef4b6f7f537df89bf72d
Cr-Commit-Position: refs/heads/master@{#320143}

Powered by Google App Engine
This is Rietveld 408576698