Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: components/components_unittests.isolate

Issue 996173004: Convert more isolate files to respect use_x11 for Xvfb usage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/components_unittests.isolate
diff --git a/components/components_unittests.isolate b/components/components_unittests.isolate
index fc3491dd631832ead0253a53e9f58aeed3a021e0..e240ea724251c2eadf26adce39fd625c0805d483 100644
--- a/components/components_unittests.isolate
+++ b/components/components_unittests.isolate
@@ -3,23 +3,20 @@
# found in the LICENSE file.
{
'conditions': [
- ['OS=="android" or OS=="linux" or OS=="mac" or OS=="win"', {
+ ['use_x11==0', {
'variables': {
- 'files': [
- 'test/data/',
- '<(PRODUCT_DIR)/components_tests_resources.pak',
- ],
- },
- }],
- ['OS=="linux" or OS=="mac" or OS=="win"', {
- 'variables': {
- 'files': [
+ 'command': [
'../testing/test_env.py',
'<(PRODUCT_DIR)/components_unittests<(EXECUTABLE_SUFFIX)',
+ '--brave-new-test-launcher',
+ '--test-launcher-bot-mode',
+ '--asan=<(asan)',
+ '--msan=<(msan)',
+ '--tsan=<(tsan)',
],
},
}],
- ['OS=="linux"', {
+ ['use_x11==1', {
'variables': {
'command': [
'../testing/xvfb.py',
@@ -33,23 +30,36 @@
],
'files': [
'../testing/xvfb.py',
- '<(PRODUCT_DIR)/libffmpegsumo.so',
- '<(PRODUCT_DIR)/libosmesa.so',
'<(PRODUCT_DIR)/xdisplaycheck',
],
},
}],
- ['OS=="mac"', {
+ ['OS=="android" or OS=="linux" or OS=="mac" or OS=="win"', {
'variables': {
- 'command': [
+ 'files': [
+ 'test/data/',
+ '<(PRODUCT_DIR)/components_tests_resources.pak',
+ ],
+ },
+ }],
+ ['OS=="linux" or OS=="mac" or OS=="win"', {
+ 'variables': {
+ 'files': [
'../testing/test_env.py',
- '<(PRODUCT_DIR)/components_unittests',
- '--brave-new-test-launcher',
- '--test-launcher-bot-mode',
- '--asan=<(asan)',
- '--msan=<(msan)',
- '--tsan=<(tsan)',
+ '<(PRODUCT_DIR)/components_unittests<(EXECUTABLE_SUFFIX)',
],
+ },
+ }],
+ ['OS=="linux"', {
+ 'variables': {
+ 'files': [
+ '<(PRODUCT_DIR)/libffmpegsumo.so',
+ '<(PRODUCT_DIR)/libosmesa.so',
+ ],
+ },
+ }],
+ ['OS=="mac"', {
+ 'variables': {
'files': [
'<(PRODUCT_DIR)/ffmpegsumo.so',
'<(PRODUCT_DIR)/osmesa.so',
@@ -58,15 +68,6 @@
}],
['OS=="win"', {
'variables': {
- 'command': [
- '../testing/test_env.py',
- '<(PRODUCT_DIR)/components_unittests.exe',
- '--brave-new-test-launcher',
- '--test-launcher-bot-mode',
- '--asan=<(asan)',
- '--msan=<(msan)',
- '--tsan=<(tsan)',
- ],
'files': [
'../chrome/test/data/policy/',
'<(PRODUCT_DIR)/ffmpegsumo.dll',

Powered by Google App Engine
This is Rietveld 408576698