Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

Issue 996163005: [Cronet] Delay StartNetLog and StopNetLog until native request context is initialized (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
index b74554520b83b940556ad479154f3a2af83a136c..def9a9eaeff9c1c00cc51000d9bbfc197d4c7fa3 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
@@ -4,6 +4,7 @@
package org.chromium.net;
+import android.content.Context;
import android.content.ContextWrapper;
import android.os.ConditionVariable;
import android.os.Handler;
@@ -293,18 +294,24 @@ public class CronetUrlRequestContextTest extends CronetTestBase {
@SmallTest
@Feature({"Cronet"})
public void testNetLog() throws Exception {
- mActivity = launchCronetTestApp();
- File directory = new File(PathUtils.getDataDirectory(
- getInstrumentation().getTargetContext()));
+ Context context = getInstrumentation().getTargetContext();
+ File directory = new File(PathUtils.getDataDirectory(context));
File file = File.createTempFile("cronet", "json", directory);
- mActivity.mUrlRequestContext.startNetLogToFile(file.getPath());
+ CronetUrlRequestContext requestContext = new CronetUrlRequestContext(
+ context,
+ new UrlRequestContextConfig().setLibraryName("cronet_tests"));
+ // Start NetLog immediately after the request context is created to make
+ // sure that the call won't crash the app even when the native request
+ // context is not fully initialized. See crbug.com/470196.
+ requestContext.startNetLogToFile(file.getPath());
+
// Start a request.
TestUrlRequestListener listener = new TestUrlRequestListener();
- UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
+ UrlRequest request = requestContext.createRequest(
TEST_URL, listener, listener.getExecutor());
- urlRequest.start();
+ request.start();
listener.blockForDone();
- mActivity.mUrlRequestContext.stopNetLog();
+ requestContext.stopNetLog();
assertTrue(file.exists());
assertTrue(file.length() != 0);
assertTrue(file.delete());

Powered by Google App Engine
This is Rietveld 408576698