[Cronet] Delay StartNetLog and StopNetLog until native request context is initialized

components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net;
 
+import android.content.Context;
 import android.content.ContextWrapper;
 import android.os.ConditionVariable;
 import android.os.Handler;
 import android.os.Looper;
 import android.test.suitebuilder.annotation.SmallTest;
 
 import org.chromium.base.PathUtils;
 import org.chromium.base.test.util.Feature;
 import org.chromium.net.TestUrlRequestListener.FailureType;
 import org.chromium.net.TestUrlRequestListener.ResponseStep;
@@ skipping 269 matching lines @@
         // Cancel happens when listener returns.
         listener.openBlockedStep();
         Thread.sleep(1000);
 
         mActivity.mUrlRequestContext.shutdown();
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testNetLog() throws Exception {
-        mActivity = launchCronetTestApp();
-        File directory = new File(PathUtils.getDataDirectory(
-                getInstrumentation().getTargetContext()));
+        Context context = getInstrumentation().getTargetContext();
+        File directory = new File(PathUtils.getDataDirectory(context));
         File file = File.createTempFile("cronet", "json", directory);
-        mActivity.mUrlRequestContext.startNetLogToFile(file.getPath());
+        CronetUrlRequestContext requestContext = new CronetUrlRequestContext(
+                context,
+                new UrlRequestContextConfig().setLibraryName("cronet_tests"));
+        // Start NetLog immediately after the request context is created to make
+        // sure that the call won't crash the app even when the native request
+        // context is not fully initialized. See crbug.com/470196.
+        requestContext.startNetLogToFile(file.getPath());
+
         // Start a request.
         TestUrlRequestListener listener = new TestUrlRequestListener();
-        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
+        UrlRequest request = requestContext.createRequest(
                 TEST_URL, listener, listener.getExecutor());
-        urlRequest.start();
+        request.start();
         listener.blockForDone();
-        mActivity.mUrlRequestContext.stopNetLog();
+        requestContext.stopNetLog();
         assertTrue(file.exists());
         assertTrue(file.length() != 0);
         assertTrue(file.delete());
         assertTrue(!file.exists());
     }
 
     @SmallTest
     @Feature({"Cronet"})
     public void testNetLogAfterShutdown() throws Exception {
         mActivity = launchCronetTestApp();
@@ skipping 288 matching lines @@
                 new CronetUrlRequestContext(mActivity, mActivity.getContextConfig());
         CronetUrlRequestContext secondContext = new CronetUrlRequestContext(
                 mActivity.getApplicationContext(), mActivity.getContextConfig());
         CronetUrlRequestContext thirdContext = new CronetUrlRequestContext(
                 new ContextWrapper(mActivity), mActivity.getContextConfig());
         firstContext.shutdown();
         secondContext.shutdown();
         thirdContext.shutdown();
     }
 }