Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: src/transitions.cc

Issue 996133002: correctly invalidate global cells (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: weak cell check Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/hydrogen.cc ('K') | « src/runtime/runtime-debug.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/transitions.cc
diff --git a/src/transitions.cc b/src/transitions.cc
index fa5ed7bb7deb5f3d73fc9d3a7cf240c13ce00580..0a99d81ab9c66fd618202c1f185d372ff0f4de2a 100644
--- a/src/transitions.cc
+++ b/src/transitions.cc
@@ -36,9 +36,10 @@ void TransitionArray::Insert(Handle<Map> map, Handle<Name> name,
Map* old_target = GetSimpleTransition(map->raw_transitions());
Name* key = GetSimpleTransitionKey(old_target);
PropertyDetails old_details = GetSimpleTargetDetails(old_target);
- PropertyDetails new_details = is_special_transition
- ? PropertyDetails(NONE, DATA, 0)
- : GetTargetDetails(*name, *target);
+ PropertyDetails new_details =
+ is_special_transition
+ ? PropertyDetails(NONE, DATA, 0, PropertyCellType::kInvalid)
+ : GetTargetDetails(*name, *target);
if (flag == SIMPLE_PROPERTY_TRANSITION && key->Equals(*name) &&
old_details.kind() == new_details.kind() &&
old_details.attributes() == new_details.attributes()) {
@@ -66,9 +67,10 @@ void TransitionArray::Insert(Handle<Map> map, Handle<Name> name,
int new_nof = 0;
int insertion_index = kNotFound;
DCHECK_EQ(is_special_transition, IsSpecialTransition(*name));
- PropertyDetails details = is_special_transition
- ? PropertyDetails(NONE, DATA, 0)
- : GetTargetDetails(*name, *target);
+ PropertyDetails details =
+ is_special_transition
+ ? PropertyDetails(NONE, DATA, 0, PropertyCellType::kInvalid)
+ : GetTargetDetails(*name, *target);
{
DisallowHeapAllocation no_gc;
« src/hydrogen.cc ('K') | « src/runtime/runtime-debug.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698