Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1178)

Unified Diff: src/runtime/runtime-debug.cc

Issue 996133002: correctly invalidate global cells (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: weak cell check Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/runtime/runtime-debug.cc
diff --git a/src/runtime/runtime-debug.cc b/src/runtime/runtime-debug.cc
index 42e60127b8b18dce3fd9f3ee4f81dfae16d762d7..ff70264ec662dd70d00f3eafba6708de5057d688 100644
--- a/src/runtime/runtime-debug.cc
+++ b/src/runtime/runtime-debug.cc
@@ -138,7 +138,8 @@ RUNTIME_FUNCTION(Runtime_DebugGetPropertyDetails) {
isolate, element_or_char,
Runtime::GetElementOrCharAt(isolate, obj, index));
details->set(0, *element_or_char);
- details->set(1, PropertyDetails(NONE, DATA, 0).AsSmi());
+ details->set(
+ 1, PropertyDetails(NONE, DATA, 0, PropertyCellType::kInvalid).AsSmi());
return *isolate->factory()->NewJSArrayWithElements(details);
}
@@ -159,9 +160,10 @@ RUNTIME_FUNCTION(Runtime_DebugGetPropertyDetails) {
isolate->factory()->NewFixedArray(has_js_accessors ? 6 : 3);
details->set(0, *value);
// TODO(verwaest): Get rid of this random way of handling interceptors.
- PropertyDetails d = it.state() == LookupIterator::INTERCEPTOR
- ? PropertyDetails(NONE, DATA, 0)
- : it.property_details();
+ PropertyDetails d =
+ it.state() == LookupIterator::INTERCEPTOR
+ ? PropertyDetails(NONE, DATA, 0, PropertyCellType::kInvalid)
+ : it.property_details();
details->set(1, d.AsSmi());
details->set(
2, isolate->heap()->ToBoolean(it.state() == LookupIterator::INTERCEPTOR));
« src/hydrogen.cc ('K') | « src/runtime/runtime.cc ('k') | src/transitions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698