src/runtime/runtime.cc - Issue 996133002: correctly invalidate global cells

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime.cc

Issue 996133002: correctly invalidate global cells (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: weak cell check Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime.cc

diff --git a/src/runtime/runtime.cc b/src/runtime/runtime.cc

index 776239aa4283233e04cb85576f7bc53c598a9ede..d23ac93ac61abb2740cbaa00b852728d1f5a330b 100644

--- a/src/runtime/runtime.cc

+++ b/src/runtime/runtime.cc

@@ -56,7 +56,8 @@ void Runtime::InitializeIntrinsicFunctionNames(Isolate* isolate,

if (name == NULL) continue;

Handle<NameDictionary> new_dict = NameDictionary::Add(

dict, isolate->factory()->InternalizeUtf8String(name),

- Handle<Smi>(Smi::FromInt(i), isolate), PropertyDetails(NONE, DATA, 0));

+ Handle<Smi>(Smi::FromInt(i), isolate),

+ PropertyDetails(NONE, DATA, 0, PropertyCellType::kInvalid));

// The dictionary does not need to grow.

CHECK(new_dict.is_identical_to(dict));

}