src/code-stubs-hydrogen.cc - Issue 996133002: correctly invalidate global cells

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/code-stubs-hydrogen.cc

Issue 996133002: correctly invalidate global cells (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: weak cell check Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/code-stubs-hydrogen.cc

diff --git a/src/code-stubs-hydrogen.cc b/src/code-stubs-hydrogen.cc

index f776abc043cb8d7e8f4c26f4ad4365819df2f5c8..0588d7b2d64b2a179440205786404710fde64cee 100644

--- a/src/code-stubs-hydrogen.cc

+++ b/src/code-stubs-hydrogen.cc

@@ -1354,6 +1354,7 @@ HValue* CodeStubGraphBuilder<StoreGlobalStub>::BuildCodeInitializedStub() {

StoreGlobalStub::property_cell_placeholder(isolate())));

HValue* cell = Add<HLoadNamedField>(weak_cell, nullptr,

HObjectAccess::ForWeakCellValue());

+ Add<HCheckHeapObject>(cell);

HObjectAccess access(HObjectAccess::ForCellPayload(isolate()));

HValue* cell_contents = Add<HLoadNamedField>(cell, nullptr, access);

« no previous file with comments | « src/bootstrapper.cc ('k') | src/factory.h » ('j') | src/hydrogen.cc » ('J')