src/bootstrapper.cc - Issue 996133002: correctly invalidate global cells

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/bootstrapper.cc

Issue 996133002: correctly invalidate global cells (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: weak cell check Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/bootstrapper.cc

diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc

index 9b378b92bb5afa23726f719a2446c77817aeb31a..72b020efc284f31e8f037444af64f29915cfef22 100644

--- a/src/bootstrapper.cc

+++ b/src/bootstrapper.cc

@@ -2703,7 +2703,8 @@ void Genesis::TransferNamedProperties(Handle<JSObject> from,

DCHECK(!to->HasFastProperties());

// Add to dictionary.

Handle<Object> callbacks(descs->GetCallbacksObject(i), isolate());

- PropertyDetails d(details.attributes(), ACCESSOR_CONSTANT, i + 1);

+ PropertyDetails d(details.attributes(), ACCESSOR_CONSTANT, i + 1,

+ PropertyCellType::kMutable);

JSObject::SetNormalizedProperty(to, key, callbacks, d);

break;

}

« no previous file with comments | « no previous file | src/code-stubs-hydrogen.cc » ('j') | src/hydrogen.cc » ('J')