content/browser/service_worker/service_worker_storage.h - Issue 996123002: ServiceWorker: Ensure live registration during starting worker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_storage.h

Issue 996123002: ServiceWorker: Ensure live registration during starting worker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix tests Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_handle_unittest.cc ('k') | content/browser/service_worker/service_worker_url_request_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_storage.h

diff --git a/content/browser/service_worker/service_worker_storage.h b/content/browser/service_worker/service_worker_storage.h

index b2c0e08cdc49a724cf227c2445b58e97f58f3998..b5a65e965600ae55ab281097f81fb68ef057d569 100644

--- a/content/browser/service_worker/service_worker_storage.h

+++ b/content/browser/service_worker/service_worker_storage.h

@@ -207,12 +207,18 @@ class CONTENT_EXPORT ServiceWorkerStorage

void PurgeResources(const ResourceList& resources);

private:

+ friend class ServiceWorkerHandleTest;

friend class ServiceWorkerStorageTest;

friend class ServiceWorkerResourceStorageTest;

friend class ServiceWorkerControlleeRequestHandlerTest;

friend class ServiceWorkerContextRequestHandlerTest;

friend class ServiceWorkerRequestHandlerTest;

+ friend class ServiceWorkerURLRequestJobTest;

+ friend class ServiceWorkerVersionBrowserTest;

+ friend class ServiceWorkerVersionTest;

friend class ServiceWorkerWriteToCacheJobTest;

+ FRIEND_TEST_ALL_PREFIXES(ServiceWorkerDispatcherHostTest,

+ CleanupOnRendererCrash);

FRIEND_TEST_ALL_PREFIXES(ServiceWorkerResourceStorageTest,

DeleteRegistration_NoLiveVersion);

FRIEND_TEST_ALL_PREFIXES(ServiceWorkerResourceStorageTest,