content/browser/service_worker/service_worker_handle_unittest.cc - Issue 996123002: ServiceWorker: Ensure live registration during starting worker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_handle_unittest.cc

Issue 996123002: ServiceWorker: Ensure live registration during starting worker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix tests Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_dispatcher_host_unittest.cc ('k') | content/browser/service_worker/service_worker_storage.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_handle_unittest.cc

diff --git a/content/browser/service_worker/service_worker_handle_unittest.cc b/content/browser/service_worker/service_worker_handle_unittest.cc

index 38dd177a85ca37f38cd8f28c71cac8b6bb1058d6..57144f71bb748ffaa7a919674cf031cbab89f9c5 100644

--- a/content/browser/service_worker/service_worker_handle_unittest.cc

+++ b/content/browser/service_worker/service_worker_handle_unittest.cc

@@ -88,6 +88,17 @@ class ServiceWorkerHandleTest : public testing::Test {

1L,

helper_->context()->AsWeakPtr());

+ // Make the registration findable via storage functions.

+ helper_->context()->storage()->LazyInitialize(base::Bind(&base::DoNothing));

+ base::RunLoop().RunUntilIdle();

+ ServiceWorkerStatusCode status = SERVICE_WORKER_ERROR_FAILED;

+ helper_->context()->storage()->StoreRegistration(

+ registration_.get(),

+ version_.get(),

+ CreateReceiverOnCurrentThread(&status));

+ base::RunLoop().RunUntilIdle();

+ ASSERT_EQ(SERVICE_WORKER_OK, status);

provider_host_.reset(new ServiceWorkerProviderHost(

kRenderProcessId, kRenderFrameId, 1,

SERVICE_WORKER_PROVIDER_FOR_CONTROLLEE,