CrashReportDatabse: set the last upload attempt time from RecordUploadAttempt()

client/crash_report_database_mac.mm

Index: client/crash_report_database_mac.mm
diff --git a/client/crash_report_database_mac.mm b/client/crash_report_database_mac.mm
index 75f63f47e573fb075563e68eccf2ca4db546335d..ffa7b2b66f76aba11047952689f02a7d7667636f 100644
--- a/client/crash_report_database_mac.mm
+++ b/client/crash_report_database_mac.mm
@@ -20,6 +20,7 @@
 #include <stdio.h>
 #include <sys/stat.h>
 #include <sys/types.h>
+#include <time.h>
 #include <unistd.h>
 #include <uuid/uuid.h>
 
@@ -399,9 +400,9 @@ CrashReportDatabaseMac::RecordUploadAttempt(const Report* report,
   if (!WriteXattr(report_path, XattrName(kXattrCollectorID), id)) {
     return kDatabaseError;
   }
-  if (!WriteXattrTimeT(report_path,
-                       XattrName(kXattrLastUploadTime),
-                       time(nullptr))) {
+
+  time_t now = time(nullptr);
+  if (!WriteXattrTimeT(report_path, XattrName(kXattrLastUploadTime), now)) {
     return kDatabaseError;
   }
 
@@ -415,6 +416,10 @@ CrashReportDatabaseMac::RecordUploadAttempt(const Report* report,
     return kDatabaseError;
   }
 
+  if (!settings_.SetLastUploadAttemptTime(now)) {
+    return kDatabaseError;

[Mark Mentovai, 2015/03/10 16:02:57]

We could also come up with a new enum value just for this, but this would be the
only place it’s used.

[Robert Sesek, 2015/03/10 16:13:10]

I think this is fine.

+  }
+
   return kNoError;
 }