CrashReportDatabse: set the last upload attempt time from RecordUploadAttempt()

client/crash_report_database_mac.mm

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #include "client/crash_report_database.h"
 
 #include <errno.h>
 #include <fcntl.h>
 #import <Foundation/Foundation.h>
 #include <stdio.h>
 #include <sys/stat.h>
 #include <sys/types.h>
+#include <time.h>
 #include <unistd.h>
 #include <uuid/uuid.h>
 
 #include "base/logging.h"
 #include "base/mac/scoped_nsautorelease_pool.h"
 #include "base/posix/eintr_wrapper.h"
 #include "base/scoped_generic.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/sys_string_conversions.h"
@@ skipping 359 matching lines @@
     }
     report_path = new_path;
   }
 
   if (!WriteXattrBool(report_path, XattrName(kXattrIsUploaded), successful)) {
     return kDatabaseError;
   }
   if (!WriteXattr(report_path, XattrName(kXattrCollectorID), id)) {
     return kDatabaseError;
   }
-  if (!WriteXattrTimeT(report_path,
-                       XattrName(kXattrLastUploadTime),
-                       time(nullptr))) {
+
+  time_t now = time(nullptr);
+  if (!WriteXattrTimeT(report_path, XattrName(kXattrLastUploadTime), now)) {
     return kDatabaseError;
   }
 
   int upload_attempts = 0;
   std::string name = XattrName(kXattrUploadAttemptCount);
   if (ReadXattrInt(report_path, name, &upload_attempts) ==
           XattrStatus::kOtherError) {
     return kDatabaseError;
   }
   if (!WriteXattrInt(report_path, name, ++upload_attempts)) {
     return kDatabaseError;
   }
 
+  if (!settings_.SetLastUploadAttemptTime(now)) {
+    return kDatabaseError;

[Mark Mentovai, 2015/03/10 16:02:57]

We could also come up with a new enum value just for this, but this would be the
only place it’s used.

[Robert Sesek, 2015/03/10 16:13:10]

I think this is fine.

+  }
+
   return kNoError;
 }
 
 CrashReportDatabase::OperationStatus CrashReportDatabaseMac::SkipReportUpload(
     const UUID& uuid) {
   base::FilePath report_path = LocateCrashReport(uuid);
   if (report_path.empty())
     return kReportNotFound;
 
   base::ScopedFD lock(ObtainReportLock(report_path));
@@ skipping 137 matching lines @@
     const base::FilePath& path) {
   scoped_ptr<CrashReportDatabaseMac> database_mac(
       new CrashReportDatabaseMac(path.Append(kDatabaseDirectoryName)));
   if (!database_mac->Initialize())
     database_mac.reset();
 
   return scoped_ptr<CrashReportDatabase>(database_mac.release());
 }
 
 }  // namespace crashpad