Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 995853003: CrashReportDatabse: set the last upload attempt time from RecordUploadAttempt() (Closed)

Created:
5 years, 9 months ago by Mark Mentovai
Modified:
5 years, 9 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

CrashReportDatabse: set the last upload attempt time from RecordUploadAttempt(). This is only implemented for CrashReportDatabaseMac, because CrashReportDatabaseWin does not currently have a Settings object. See bug crashpad:13. TEST=crashpad_client_test CrashReportDatabaseTest.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/4ef649d1896a5a2ed45dd58c962eb3157bf3d420

Patch Set 1 #

Patch Set 2 : kDatabaseError #

Total comments: 2

Patch Set 3 : Windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -8 lines) Patch
M client/crash_report_database.h View 1 2 chunks +6 lines, -4 lines 0 comments Download
M client/crash_report_database_mac.mm View 3 chunks +8 lines, -3 lines 0 comments Download
M client/crash_report_database_test.cc View 1 2 5 chunks +49 lines, -1 line 0 comments Download
M client/crash_report_database_win.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Mark Mentovai
https://codereview.chromium.org/995853003/diff/20001/client/crash_report_database_mac.mm File client/crash_report_database_mac.mm (right): https://codereview.chromium.org/995853003/diff/20001/client/crash_report_database_mac.mm#newcode420 client/crash_report_database_mac.mm:420: return kDatabaseError; We could also come up with a ...
5 years, 9 months ago (2015-03-10 16:02:57 UTC) #2
Robert Sesek
LGTM https://codereview.chromium.org/995853003/diff/20001/client/crash_report_database_mac.mm File client/crash_report_database_mac.mm (right): https://codereview.chromium.org/995853003/diff/20001/client/crash_report_database_mac.mm#newcode420 client/crash_report_database_mac.mm:420: return kDatabaseError; On 2015/03/10 16:02:57, Mark Mentovai wrote: ...
5 years, 9 months ago (2015-03-10 16:13:10 UTC) #3
Mark Mentovai
Revised slightly for Windows compatibility.
5 years, 9 months ago (2015-03-10 16:22:06 UTC) #5
Mark Mentovai
5 years, 9 months ago (2015-03-10 16:22:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:20002) manually as
4ef649d1896a5a2ed45dd58c962eb3157bf3d420 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698