Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 995743002: Added a workaround for undefined behavior. (Closed)

Created:
5 years, 9 months ago by Sven Panne
Modified:
5 years, 9 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Added a workaround for undefined behavior. Note that this patch is not really a *solution*, it is just enough to make the undefined behavior unobservable. The real fix would be being much more correct about sizes and signedness in our code base... BUG=chromium:464657 LOG=n R=dcarney@chromium.org Committed: https://crrev.com/49c3864b4b8348a66a93f042324ae4c35d04c0c4 Cr-Commit-Position: refs/heads/master@{#27100}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/compiler/instruction.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/instruction.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Sven Panne
5 years, 9 months ago (2015-03-10 12:11:35 UTC) #3
dcarney
lgtm
5 years, 9 months ago (2015-03-10 12:12:09 UTC) #4
Sven Panne
Committed patchset #1 (id:1) manually as 49c3864b4b8348a66a93f042324ae4c35d04c0c4 (presubmit successful).
5 years, 9 months ago (2015-03-10 12:13:07 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 12:13:07 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/49c3864b4b8348a66a93f042324ae4c35d04c0c4
Cr-Commit-Position: refs/heads/master@{#27100}

Powered by Google App Engine
This is Rietveld 408576698