Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1142)

Issue 995583002: [S.P.] Use a correct bounding box for outlines of LayoutInlines for cull rects. (Closed)

Created:
5 years, 9 months ago by chrishtr
Modified:
5 years, 9 months ago
CC:
blink-reviews, blink-reviews-paint_chromium.org, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[S.P.] Use a correct bounding box for outlines of LayoutInlines for cull rects. The containing block's bounds are not sufficient, because sometimes an inline can have nested content and have its own size be zero, when continuations are involved. See for example the fast/inline/continuation-outlines.html layout test. BUG=460198 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191659

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -17 lines) Patch
M Source/core/paint/InlinePainter.cpp View 1 2 2 chunks +20 lines, -12 lines 0 comments Download
M Source/core/paint/ObjectPainter.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/paint/ObjectPainter.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
chrishtr
5 years, 9 months ago (2015-03-09 23:00:39 UTC) #2
leviw_travelin_and_unemployed
lgtm
5 years, 9 months ago (2015-03-10 02:16:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/995583002/1
5 years, 9 months ago (2015-03-10 02:17:08 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/46663)
5 years, 9 months ago (2015-03-10 02:25:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/995583002/20001
5 years, 9 months ago (2015-03-10 17:02:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/995583002/40001
5 years, 9 months ago (2015-03-10 18:41:15 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 21:53:06 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191659

Powered by Google App Engine
This is Rietveld 408576698