Fix regression where the active window header was not used for apps on CrOS

Fix regression where the active window header was not used for v2 apps on CrOS

BUG=331343
TEST=Manual, see bug

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243677

[pkotwicz, 2014-01-02 16:26:39]

Sadrul, can you please take a look?
The change is pretty hacky, but the usage of ShouldPaintAsActive() in
CustomFrameViewAsh is pretty hacky too.
I think that this is better than making NonClientFrameView a
views::WidgetObserver or making CustomFrameViewAsh a views::WidgetObserver

[sadrul, 2014-01-03 17:59:51]

Removing the duplicated state from HeaderView looks like a good thing to do. But
I don't know this code well enough to know if this is the right fix.
sky@/jamescook@ would be better reviewers for this.

https://codereview.chromium.org/99553008/diff/80001/ui/views/window/non_clien...
File ui/views/window/non_client_view.cc (right):

https://codereview.chromium.org/99553008/diff/80001/ui/views/window/non_clien...
ui/views/window/non_client_view.cc:247: return GetWidget()->IsActive() ||
inactive_rendering_disabled_;
We trigger SchedulePaint() when |inactive_rendering_disabled_| is toggled. Does
something trigger a repaint when the widget's active state changes?

[pkotwicz, 2014-01-03 20:57:15]

Scott, can you please take a look?

https://codereview.chromium.org/99553008/diff/80001/ui/views/window/non_clien...
File ui/views/window/non_client_view.cc (right):

https://codereview.chromium.org/99553008/diff/80001/ui/views/window/non_clien...
ui/views/window/non_client_view.cc:247: return GetWidget()->IsActive() ||
inactive_rendering_disabled_;
Yes, NativeWidgetAura::OnWindowActivated() does this

[sky, 2014-01-06 19:13:49]

https://codereview.chromium.org/99553008/diff/80001/ui/views/window/non_clien...
File ui/views/window/non_client_view.cc (right):

https://codereview.chromium.org/99553008/diff/80001/ui/views/window/non_clien...
ui/views/window/non_client_view.cc:243: SchedulePaint();
Is this only necessary if !active?

https://codereview.chromium.org/99553008/diff/80001/ui/views/window/non_clien...
ui/views/window/non_client_view.cc:247: return GetWidget()->IsActive() ||
inactive_rendering_disabled_;
nit: check inactive_rendering_disabled_ first (it's cheaper).

https://codereview.chromium.org/99553008/diff/80001/ui/views/window/non_clien...
File ui/views/window/non_client_view.h (right):

https://codereview.chromium.org/99553008/diff/80001/ui/views/window/non_clien...
ui/views/window/non_client_view.h:30: virtual ~NonClientFrameView();
nit: after enum.

[pkotwicz, 2014-01-07 18:29:24]

Scott, can you please take another look?

[sky, 2014-01-07 21:39:34]

LGTM

[commit-bot: I haz the power, 2014-01-08 02:44:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/99553008/220001

[commit-bot: I haz the power, 2014-01-08 03:20:51]

Retried try job too often on win_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-08 16:04:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/99553008/220001

[commit-bot: I haz the power, 2014-01-08 17:29:46]

Retried try job too often on win_rel for step(s) net_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-08 17:32:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/99553008/220001

[commit-bot: I haz the power, 2014-01-08 22:44:39]

Change committed as 243677