Fix regression where the active window header was not used for apps on CrOS

ui/views/window/non_client_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/window/non_client_view.h"
 
 #include "ui/base/accessibility/accessible_view_state.h"
 #include "ui/base/hit_test.h"
 #include "ui/gfx/rect_conversions.h"
 #include "ui/views/rect_based_targeting_utils.h"
@@ skipping 214 matching lines @@
     if (handler)
       return handler;
   }
 
   return View::GetTooltipHandlerForPoint(point);
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // NonClientFrameView, public:
 
+NonClientFrameView::~NonClientFrameView() {
+}
+
 void NonClientFrameView::SetInactiveRenderingDisabled(bool disable) {
-  if (paint_as_active_ == disable)
+  if (inactive_rendering_disabled_ == disable)
     return;
 
-  paint_as_active_ = disable;
-  ShouldPaintAsActiveChanged();
+  inactive_rendering_disabled_ = disable;
+  SchedulePaint();

[sky, 2014/01/06 19:13:49]

Is this only necessary if !active?

+}
+
+bool NonClientFrameView::ShouldPaintAsActive() const {
+  return GetWidget()->IsActive() || inactive_rendering_disabled_;

[sadrul, 2014/01/03 17:59:51]

We trigger SchedulePaint() when |inactive_rendering_disabled_| is toggled. Does
something trigger a repaint when the widget's active state changes?

[pkotwicz, 2014/01/03 20:57:16]

Yes, NativeWidgetAura::OnWindowActivated() does this

[sky, 2014/01/06 19:13:49]

nit: check inactive_rendering_disabled_ first (it's cheaper).

 }
 
 int NonClientFrameView::GetHTComponentForFrame(const gfx::Point& point,
                                                int top_resize_border_height,
                                                int resize_border_thickness,
                                                int top_resize_corner_height,
                                                int resize_corner_width,
                                                bool can_resize) {
   // Tricky: In XP, native behavior is to return HTTOPLEFT and HTTOPRIGHT for
   // a |resize_corner_size|-length strip of both the side and top borders, but
@@ skipping 43 matching lines @@
 
 bool NonClientFrameView::HitTestRect(const gfx::Rect& rect) const {
   // For the default case, we assume the non-client frame view never overlaps
   // the client view.
   return !GetWidget()->client_view()->bounds().Intersects(rect);
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // NonClientFrameView, protected:
 
-bool NonClientFrameView::ShouldPaintAsActive() const {
-  return GetWidget()->IsActive() || paint_as_active_;
-}
-
-void NonClientFrameView::ShouldPaintAsActiveChanged() {
-  SchedulePaint();
-}
-
 void NonClientFrameView::GetAccessibleState(ui::AccessibleViewState* state) {
   state->role = ui::AccessibilityTypes::ROLE_CLIENT;
 }
 
 const char* NonClientFrameView::GetClassName() const {
   return kViewClassName;
 }
 
 void NonClientFrameView::OnBoundsChanged(const gfx::Rect& previous_bounds) {
   // Overridden to do nothing. The NonClientView manually calls Layout on the
   // FrameView when it is itself laid out, see comment in NonClientView::Layout.
 }
 
+NonClientFrameView::NonClientFrameView() : inactive_rendering_disabled_(false) {
+}
+
 }  // namespace views