Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2965)

Unified Diff: base/compiler_specific.h

Issue 99523009: Move DumpProcessWithoutCrash to base, so we can use it from net and content (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/base.gypi ('k') | base/debug/dump_without_crashing.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/compiler_specific.h
diff --git a/base/compiler_specific.h b/base/compiler_specific.h
index dc4b23349873c8ae81e0312badd109bf2416f222..19a7f12f243c451daafd69d55e601102ca961e57 100644
--- a/base/compiler_specific.h
+++ b/base/compiler_specific.h
@@ -211,4 +211,11 @@ void __msan_unpoison(const void *p, unsigned long s);
#define MSAN_UNPOISON(p, s)
#endif // MEMORY_SANITIZER
+// Macro useful for writing cross-platform function pointers.
+#if defined(OS_WIN) && !defined(CDECL)
Mark Mentovai 2013/12/18 13:47:49 When would CDECL be already defined? Because if it
jochen (gone - plz use gerrit) 2013/12/18 14:49:41 no idea, I just copied this verbatim from native_l
+#define CDECL __cdecl
+#else
+#define CDECL
Mark Mentovai 2013/12/18 13:47:49 …it might also be defined for non-Windows, and thi
jochen (gone - plz use gerrit) 2013/12/18 14:49:41 I wrapped the entire block in #if !defined(CDECL)
+#endif
+
#endif // BASE_COMPILER_SPECIFIC_H_
« no previous file with comments | « base/base.gypi ('k') | base/debug/dump_without_crashing.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698