base/compiler_specific.h - Issue 99523009: Move DumpProcessWithoutCrash to base, so we can use it from net and content

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/compiler_specific.h

Issue 99523009: Move DumpProcessWithoutCrash to base, so we can use it from net and content (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: updates Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef BASE_COMPILER_SPECIFIC_H_	5 #ifndef BASE_COMPILER_SPECIFIC_H_

6 #define BASE_COMPILER_SPECIFIC_H_	6 #define BASE_COMPILER_SPECIFIC_H_

7	7

8 #include "build/build_config.h"	8 #include "build/build_config.h"

9	9

10 #if defined(COMPILER_MSVC)	10 #if defined(COMPILER_MSVC)

(...skipping 193 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
204 } // extern "C"	204 } // extern "C"

205	205

206 // Mark a memory region fully initialized.	206 // Mark a memory region fully initialized.

207 // Use this to annotate code that deliberately reads uninitialized data, for	207 // Use this to annotate code that deliberately reads uninitialized data, for

208 // example a GC scavenging root set pointers from the stack.	208 // example a GC scavenging root set pointers from the stack.

209 #define MSAN_UNPOISON(p, s) __msan_unpoison(p, s)	209 #define MSAN_UNPOISON(p, s) __msan_unpoison(p, s)

210 #else // MEMORY_SANITIZER	210 #else // MEMORY_SANITIZER

211 #define MSAN_UNPOISON(p, s)	211 #define MSAN_UNPOISON(p, s)

212 #endif // MEMORY_SANITIZER	212 #endif // MEMORY_SANITIZER

213	213

	214 // Macro useful for writing cross-platform function pointers.

	215 #if defined(OS_WIN) && !defined(CDECL)
	Mark Mentovai 2013/12/18 13:47:49 When would CDECL be already defined? Because if it When would CDECL be already defined? Because if it might be defined by something like this snippet… jochen (gone - plz use gerrit) 2013/12/18 14:49:41 no idea, I just copied this verbatim from native_l Show quoted text On 2013/12/18 13:47:49, Mark Mentovai wrote: > When would CDECL be already defined? Because if it might be defined by something > like this snippet… no idea, I just copied this verbatim from native_library.h
	216 #define CDECL __cdecl

	217 #else

	218 #define CDECL
	Mark Mentovai 2013/12/18 13:47:49 …it might also be defined for non-Windows, and thi …it might also be defined for non-Windows, and this could be a problem because you only checked !defined for OS_WIN. jochen (gone - plz use gerrit) 2013/12/18 14:49:41 I wrapped the entire block in #if !defined(CDECL) Show quoted text On 2013/12/18 13:47:49, Mark Mentovai wrote: > …it might also be defined for non-Windows, and this could be a problem because > you only checked !defined for OS_WIN. I wrapped the entire block in #if !defined(CDECL)
	219 #endif

	220

214 #endif // BASE_COMPILER_SPECIFIC_H_	221 #endif // BASE_COMPILER_SPECIFIC_H_

OLD	NEW

« no previous file with comments | « base/base.gypi ('k') | base/debug/dump_without_crashing.h » ('j') | no next file with comments »