Issue 99523008: Make GrBicubicEffect take tile modes rather than GrTextureParams.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99523008: Make GrBicubicEffect take tile modes rather than GrTextureParams. (Closed)

Created:
7 years ago by bsalomon

Modified:
7 years ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Make GrBicubicEffect take tile modes rather than GrTextureParams. GrTextureParams allows the caller to override the filter mode. But no filtering other than nearest neighbor makes sense. Also removes coord set from creation signature since it is unused. Committed: http://code.google.com/p/skia/source/detail?r=12591

Patch Set 1 #

Patch Set 2 : remove aborted comment #

Patch Set 3 : fix const, remove 2nd GrBicubicEffect cons #

Patch Set 4 : small simplification #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -36 lines)			Patch
M	include/gpu/GrTextureAccess.h	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/core/SkBitmapProcShader.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/gpu/effects/GrBicubicEffect.h	View	1 2 3	1 chunk	+27 lines, -17 lines	0 comments	Download
M	src/gpu/effects/GrBicubicEffect.cpp	View	1 2	1 chunk	+2 lines, -15 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/99523008/60001

7 years ago (2013-12-09 19:34:54 UTC) #3

Message was sent while issue was closed.

Change committed as 12591

Expand Messages | Collapse Messages