Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 995183005: CpuProfiler: replace FLAG_hydrogen_track_positions with is_tracking_positions method on Compilation… (Closed)

Created:
5 years, 9 months ago by loislo
Modified:
5 years, 9 months ago
Reviewers:
Sven Panne, alph, yurys
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

CpuProfiler: replace FLAG_hydrogen_track_positions with is_tracking_positions method on CompilationInfo this is the second part of https://codereview.chromium.org/1012633002. almost mechanical change. I'd like to enable positions tracking when cpu profiler is working. But I'll switch it on for cpu-profiler in another patch. BUG=chromium:452067 LOG=n Committed: https://crrev.com/dc3f240e53c91e13adae991329301c03ec723a99 Cr-Commit-Position: refs/heads/master@{#27224}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments addressed #

Patch Set 3 : rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -27 lines) Patch
M src/compiler.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M src/compiler.cc View 1 2 5 chunks +9 lines, -6 lines 0 comments Download
M src/hydrogen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 14 chunks +19 lines, -20 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
loislo
PTAL
5 years, 9 months ago (2015-03-16 12:54:05 UTC) #2
Sven Panne
lgtm
5 years, 9 months ago (2015-03-16 13:13:24 UTC) #3
yurys
https://codereview.chromium.org/995183005/diff/1/src/compiler.cc File src/compiler.cc (right): https://codereview.chromium.org/995183005/diff/1/src/compiler.cc#newcode291 src/compiler.cc:291: if (FLAG_hydrogen_track_positions) { && !script->source()->IsUndefined()
5 years, 9 months ago (2015-03-16 13:16:11 UTC) #4
loislo
comments addressed https://codereview.chromium.org/995183005/diff/1/src/compiler.cc File src/compiler.cc (right): https://codereview.chromium.org/995183005/diff/1/src/compiler.cc#newcode291 src/compiler.cc:291: if (FLAG_hydrogen_track_positions) { On 2015/03/16 at 13:16:11, ...
5 years, 9 months ago (2015-03-16 13:20:58 UTC) #5
yurys
lgtm
5 years, 9 months ago (2015-03-16 13:30:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/995183005/40001
5 years, 9 months ago (2015-03-16 13:47:55 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-16 14:17:08 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 14:17:25 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/dc3f240e53c91e13adae991329301c03ec723a99
Cr-Commit-Position: refs/heads/master@{#27224}

Powered by Google App Engine
This is Rietveld 408576698