Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1012633002: CpuProfiler: Push inlining data forward to cpu profiler. (Closed)

Created:
5 years, 9 months ago by loislo
Modified:
5 years, 9 months ago
Reviewers:
Sven Panne, alph, yurys
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

CpuProfiler: Push the inlining data forward to cpu profiler. The schema: 0) make inlining id accessible via LEnvironment->entry 1) push the map between pc_offset and inlining id into CodeEntry 2) collect inlining tree (script_ids, start_positions and inlining_positions) and put it into CodeEntry 3) In order of processing CodeDeoptEvent take the branch from the inlining tree where deopt has happened and put it into ProfileNode as DeoptInfo. 4) Dump this information as part of ProfileTree BUG=chromium:452067 LOG=n

Patch Set 1 #

Patch Set 2 : signed/unsigned comparison was fixed #

Patch Set 3 : size_t vs int #

Patch Set 4 : rebaselined #

Patch Set 5 : rebaselined #

Patch Set 6 : unnecessary change was removed #

Patch Set 7 : unnecessary change was removed #

Patch Set 8 : win64 fix #

Patch Set 9 : rebaselined #

Patch Set 10 : rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+351 lines, -28 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -0 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -0 lines 0 comments Download
M src/compiler.h View 1 2 3 4 5 2 chunks +8 lines, -0 lines 0 comments Download
M src/compiler.cc View 1 2 3 4 3 chunks +10 lines, -2 lines 0 comments Download
M src/cpu-profiler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/cpu-profiler.cc View 1 2 3 4 5 6 7 3 chunks +3 lines, -0 lines 0 comments Download
M src/cpu-profiler-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 3 4 5 6 7 8 3 chunks +5 lines, -0 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -0 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -0 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -0 lines 0 comments Download
M src/profile-generator.h View 7 chunks +34 lines, -14 lines 0 comments Download
M src/profile-generator.cc View 1 3 chunks +45 lines, -9 lines 0 comments Download
M src/profile-generator-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 3 4 5 6 7 8 9 2 chunks +4 lines, -0 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 2 3 4 5 6 7 8 9 3 chunks +5 lines, -0 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 2 3 4 chunks +218 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
loislo
5 years, 9 months ago (2015-03-16 11:50:35 UTC) #2
loislo
PTAL
5 years, 9 months ago (2015-03-16 11:50:43 UTC) #3
yurys
This patch seems to be doing too many things at once. Can you split it?
5 years, 9 months ago (2015-03-16 12:26:02 UTC) #4
Sven Panne
5 years, 9 months ago (2015-03-18 08:23:58 UTC) #5
On 2015/03/16 12:26:02, yurys wrote:
> This patch seems to be doing too many things at once. Can you split it?

To make my review list less confusing: Can we close this issue?

Powered by Google App Engine
This is Rietveld 408576698