Add additional move support to ScopedGeneric in the form of operator=.

Add additional move support to ScopedGeneric in the form of operator=.

This also removes the C++03 emulated move support and uses full C++11 move semantics.

BUG=453142
R=danakj@chromium.org

Committed: https://crrev.com/9470f6bca0fc1cae01cfdf2e70f9d77588cd676e
Cr-Commit-Position: refs/heads/master@{#319990}

[danakj, 2015-03-10 20:29:13]

https://codereview.chromium.org/995093002/diff/20001/base/scoped_generic.h
File base/scoped_generic.h (right):

https://codereview.chromium.org/995093002/diff/20001/base/scoped_generic.h#ne...
base/scoped_generic.h:95: ScopedGeneric& operator=(ScopedGeneric<T, Traits>&&
rhs) {
If we're going to add rvalue references we should go all the way and replace the
C++03 emulation, like we did for scoped_ptr, I think?

You'll need approval from a styleguide/c++11 owner as well to use rvalue refs.

[Robert Sesek, 2015-03-10 20:51:15]

https://codereview.chromium.org/995093002/diff/20001/base/scoped_generic.h
File base/scoped_generic.h (right):

https://codereview.chromium.org/995093002/diff/20001/base/scoped_generic.h#ne...
base/scoped_generic.h:95: ScopedGeneric& operator=(ScopedGeneric<T, Traits>&&
rhs) {
On 2015/03/10 20:29:13, danakj wrote:
> If we're going to add rvalue references we should go all the way and replace
the
> C++03 emulation, like we did for scoped_ptr, I think?
> 
> You'll need approval from a styleguide/c++11 owner as well to use rvalue refs.

OK, replaced the emulated move with full C++11 move. I'll add a styleowner if
you have no more comments.

[danakj, 2015-03-10 20:56:34]

LGTM % rvalue refs

https://codereview.chromium.org/995093002/diff/40001/base/scoped_generic_unit...
File base/scoped_generic_unittest.cc (right):

https://codereview.chromium.org/995093002/diff/40001/base/scoped_generic_unit...
base/scoped_generic_unittest.cc:113: EXPECT_EQ(kSecond, values_freed[0]);
nit: you dont have to check [0] again

[Robert Sesek, 2015-03-10 21:00:39]

rsesek@chromium.org changed reviewers:
+ thakis@chromium.org

[Robert Sesek, 2015-03-10 21:00:40]

+thakis to approve use of a rvalue reference in ScopedGeneric

https://codereview.chromium.org/995093002/diff/40001/base/scoped_generic_unit...
File base/scoped_generic_unittest.cc (right):

https://codereview.chromium.org/995093002/diff/40001/base/scoped_generic_unit...
base/scoped_generic_unittest.cc:113: EXPECT_EQ(kSecond, values_freed[0]);
On 2015/03/10 20:56:33, danakj wrote:
> nit: you dont have to check [0] again

Done.

[Nico, 2015-03-10 21:04:30]

lgtm

[Robert Sesek, 2015-03-10 21:05:13]

The CQ bit was checked by rsesek@chromium.org

[Robert Sesek, 2015-03-10 21:05:13]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/995093002/#ps60001 (title:
"Fix nit")

[commit-bot: I haz the power, 2015-03-10 21:06:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/995093002/60001

[commit-bot: I haz the power, 2015-03-10 22:29:07]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-03-10 22:30:37]

Patchset 4 (id:??) landed as
https://crrev.com/9470f6bca0fc1cae01cfdf2e70f9d77588cd676e
Cr-Commit-Position: refs/heads/master@{#319990}