Add additional move support to ScopedGeneric in the form of operator=.

base/scoped_generic.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_SCOPED_GENERIC_H_
 #define BASE_SCOPED_GENERIC_H_
 
 #include <stdlib.h>
 
 #include <algorithm>
@@ skipping 74 matching lines @@
 
   // Move constructor for C++03 move emulation.
   ScopedGeneric(RValue rvalue)
       : data_(rvalue.object->release(), rvalue.object->get_traits()) {
   }
 
   ~ScopedGeneric() {
     FreeIfNecessary();
   }
 
+  ScopedGeneric& operator=(ScopedGeneric<T, Traits>&& rhs) {

[danakj, 2015/03/10 20:29:13]

If we're going to add rvalue references we should go all the way and replace the
C++03 emulation, like we did for scoped_ptr, I think?

You'll need approval from a styleguide/c++11 owner as well to use rvalue refs.

[Robert Sesek, 2015/03/10 20:51:15]

OK, replaced the emulated move with full C++11 move. I'll add a styleowner if
you have no more comments.

+    reset(rhs.release());
+    return *this;
+  }
+
   // Frees the currently owned object, if any. Then takes ownership of a new
   // object, if given. Self-resets are not allowd as on scoped_ptr. See
   // http://crbug.com/162971
   void reset(const element_type& value = traits_type::InvalidValue()) {
     if (data_.generic != traits_type::InvalidValue() && data_.generic == value)
       abort();
     FreeIfNecessary();
     data_.generic = value;
   }
 
@@ skipping 62 matching lines @@
 }
 
 template<class T, class Traits>
 bool operator!=(const T& value, const ScopedGeneric<T, Traits>& scoped) {
   return value != scoped.get();
 }
 
 }  // namespace base
 
 #endif  // BASE_SCOPED_GENERIC_H_