Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 995073002: Make Sky's EditableText mostly work (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
eseidel
CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, rafaelw, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make Sky's EditableText mostly work This CL factors EditableString out of EditableText and implements more of the InputConnection functions. As a result, EditableText now basically works. This CL also paves the way to make EditableText stateless by using EditableString as its state object. However, there's still a bit more work to do to make that a reality (e.g., factoring out the cursor blink timer and the connection to the keyboard). R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/507c02194dcb93c738f4fd33d1889fb4d955cd5d

Patch Set 1 #

Patch Set 2 : Less tabIndex #

Patch Set 3 : Build fix #

Patch Set 4 : More comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -119 lines) Patch
A sky/examples/editor/editable_string.dart View 1 chunk +112 lines, -0 lines 1 comment Download
A sky/examples/editor/editable_text.dart View 1 2 1 chunk +115 lines, -0 lines 0 comments Download
M sky/examples/editor/editor_app.dart View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/examples/editor/input.dart View 1 chunk +0 lines, -111 lines 0 comments Download
M sky/services/keyboard/keyboard.mojom View 1 chunk +20 lines, -3 lines 0 comments Download
M sky/services/keyboard/org/domokit/keyboard/InputConnectionAdaptor.java View 1 2 3 3 chunks +33 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-03-10 18:18:08 UTC) #1
eseidel
lgtm https://codereview.chromium.org/995073002/diff/60001/sky/examples/editor/editable_string.dart File sky/examples/editor/editable_string.dart (right): https://codereview.chromium.org/995073002/diff/60001/sky/examples/editor/editable_string.dart#newcode57 sky/examples/editor/editable_string.dart:57: text += newText; You should make this more ...
5 years, 9 months ago (2015-03-10 18:39:29 UTC) #2
abarth-chromium
5 years, 9 months ago (2015-03-10 19:32:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
507c02194dcb93c738f4fd33d1889fb4d955cd5d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698